? ? Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
23 Apr 2020

Pull Request for Issue # .

Summary of Changes

Minor fix for tooltip in user profile (see screenshots).

Before / After

Screenshot_3

Before / After - Hathor template

Screenshot_1

avatar Kostelano Kostelano - open - 23 Apr 2020
avatar Kostelano Kostelano - change - 23 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2020
Category Administration com_users Templates (admin)
avatar brianteeman
brianteeman - comment - 23 Apr 2020

Since April 2017

We strongly recommend all users to use the Isis template. The Hathor template has not been updated to work with the new features shipping with this release.
When we released Hathor it was build with accessibility in mind, but over the years the Isis template has been improved in terms of accessibility and supporting technologies. We now believe that the Isis template is as good as or possibly better than Hathor.
To ensure a smooth experience for our users, during the update process, the default administrator template will be switched to Isis. You are free to switch this back after the update but we cannot guarantee and in fact know that many features will not work with Hathor.

avatar infograf768
infograf768 - comment - 23 Apr 2020

This solution has the advantage of not modifying the lang strings.
But, normally, we should use a sprintf and modify the label string to include a br and a variable which would load the desc.
This Pr is not only for hathor...

avatar Quy
Quy - comment - 23 Apr 2020

or convert it to be a popover to be consistent with other fields.

28771-popover

avatar infograf768
infograf768 - comment - 24 Apr 2020

hmm
at this time, using isis or Hathor, we do have correctly
Screen Shot 2020-04-24 at 07 44 42
Screen Shot 2020-04-24 at 07 47 59

Firefox Macintosh.

avatar infograf768
infograf768 - comment - 24 Apr 2020

But, as @Quy says we can use popover to normalise with other tips

			<div class="control-label">
				<?php JHtml::_('bootstrap.popover');
					$text        = JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL');
					$description = JText::_('COM_USERS_USER_FIELD_TWOFACTOR_DESC');
					$position    = null;
					$title       = ' title="' . htmlspecialchars(trim($text, ':')) . '"'
						. ' data-content="'. htmlspecialchars($description) . '"';

					if (JFactory::getLanguage()->isRtl())
					{
						$position = ' data-placement="left" ';
					}
				?>
				<label id="jform_twofactor_method-lbl" for="jform_twofactor_method" class="hasPopover"
						<?php echo $title; ?><?php echo $position; ?>>
					<?php echo JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL'); ?>
				</label>
			</div>
avatar infograf768
infograf768 - comment - 25 Apr 2020

@Kostelano
Are you going to update your PR with the code I provided or shall we close this and I will make a new PR?

avatar Kostelano Kostelano - change - 25 Apr 2020
Labels Added: ? ?
avatar Kostelano
Kostelano - comment - 25 Apr 2020

Yes of course. I apologize for not being able to answer earlier.
I changed this according to your recommendation.
Everything works, thank you.

Screenshot_1

avatar infograf768
infograf768 - comment - 26 Apr 2020

There are issues with wrong end of line and a concat code style

avatar Kostelano Kostelano - change - 3 May 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-05-03 12:53:50
Closed_By Kostelano
Labels Added: ?
Removed: ?
avatar Kostelano Kostelano - close - 3 May 2020

Add a Comment

Login with GitHub to post a comment