User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_users Templates (admin) |
This solution has the advantage of not modifying the lang strings.
But, normally, we should use a sprintf and modify the label string to include a br and a variable which would load the desc.
This Pr is not only for hathor...
But, as @Quy says we can use popover to normalise with other tips
<div class="control-label">
<?php JHtml::_('bootstrap.popover');
$text = JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL');
$description = JText::_('COM_USERS_USER_FIELD_TWOFACTOR_DESC');
$position = null;
$title = ' title="' . htmlspecialchars(trim($text, ':')) . '"'
. ' data-content="'. htmlspecialchars($description) . '"';
if (JFactory::getLanguage()->isRtl())
{
$position = ' data-placement="left" ';
}
?>
<label id="jform_twofactor_method-lbl" for="jform_twofactor_method" class="hasPopover"
<?php echo $title; ?><?php echo $position; ?>>
<?php echo JText::_('COM_USERS_USER_FIELD_TWOFACTOR_LABEL'); ?>
</label>
</div>
@Kostelano
Are you going to update your PR with the code I provided or shall we close this and I will make a new PR?
Labels |
Added:
?
?
|
There are issues with wrong end of line and a concat code style
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-03 12:53:50 |
Closed_By | ⇒ | Kostelano | |
Labels |
Added:
?
Removed: ? |
Since April 2017