Feeling Lucky
?
?
[#28756] - [4.0][Atum] Rewrite sidebar CSS
- Fixed in Code Base
- 24 Apr 2020
- Medium
- Build: 4.0-dev
- # 28756
- Diff
- ciar4n:sidebar-rewrite
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28704, #28706, #28738, #28208 .
Summary of Changes
Rewrites the Atum admin template sidebar CSS
- Removes 300+ lines of SCSS (over half).
- Fixes mobile menu toggle animation
- Fixes cropped mobile menu
- Removes redundant class rules
- More maintainable and concise code
- Removes double scroll bar when not needed on mobile
Testing Instructions
Apply this patch and run node build.js --compile-css to update the changed SCSS. Check sidebar works correctly
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) |
| Labels |
Added:
?
|
||
Quy
- comment
- 22 Apr 2020
This box is no longer in the footer.
jwaisner
- comment
- 23 Apr 2020
I have tested this item
Tested and looks good on Desktop browser.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28756.
Quy
- comment
- 23 Apr 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28756.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 23 Apr 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28756.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-24 13:56:12 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thank you. I have tested this PR and for me it is good and the sidebar works correctly. The only thing that bothered me was that site was not indented equally.