? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
22 Apr 2020

Pull Request for Issue #28704, #28706, #28738, #28208 .

Summary of Changes

Rewrites the Atum admin template sidebar CSS

  • Removes 300+ lines of SCSS (over half).
  • Fixes mobile menu toggle animation
  • Fixes cropped mobile menu
  • Removes redundant class rules
  • More maintainable and concise code
  • Removes double scroll bar when not needed on mobile

Testing Instructions

Apply this patch and run node build.js --compile-css to update the changed SCSS. Check sidebar works correctly

Expected result

Actual result

Documentation Changes Required

avatar ciar4n ciar4n - open - 22 Apr 2020
avatar ciar4n ciar4n - change - 22 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2020
Category Modules Administration Templates (admin)
avatar ciar4n ciar4n - change - 22 Apr 2020
Labels Added: ?
avatar astridx
astridx - comment - 22 Apr 2020

Thank you. I have tested this PR and for me it is good and the sidebar works correctly. The only thing that bothered me was that site was not indented equally.

Help   test   Administration(1)
Help   test   Administration(2)

avatar Quy
Quy - comment - 22 Apr 2020

This box is no longer in the footer.

login

03c893c 23 Apr 2020 avatar ciar4n fixes
avatar ciar4n
ciar4n - comment - 23 Apr 2020

@Quy @astridx Thank you. Should be sorted with 03c893c

avatar ciar4n ciar4n - change - 23 Apr 2020
The description was changed
avatar ciar4n ciar4n - edited - 23 Apr 2020
avatar jwaisner
jwaisner - comment - 23 Apr 2020

I have tested this item successfully on 03c893c

Tested and looks good on Desktop browser.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28756.

avatar jwaisner jwaisner - test_item - 23 Apr 2020 - Tested successfully
avatar Quy
Quy - comment - 23 Apr 2020

I have tested this item successfully on 03c893c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28756.

avatar Quy Quy - test_item - 23 Apr 2020 - Tested successfully
avatar Quy Quy - change - 23 Apr 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28756.

avatar wilsonge wilsonge - close - 24 Apr 2020
avatar wilsonge wilsonge - merge - 24 Apr 2020
avatar wilsonge wilsonge - change - 24 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-24 13:56:12
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 24 Apr 2020

Thankyou @ciar4n !!

Add a Comment

Login with GitHub to post a comment