[#28746] - Fix tags single instance view
- Fixed in Code Base
- 21 Apr 2020
- Medium
- Build: staging
- # 28746
- Diff
- wilsonge:fix/tags-single-view
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Single tags view creates a 404 when viewing a tag. Introduced in #28610
Whilst hit doesn't need to load the article hasPrimaryKey a few lines later does.
Testing Instructions
View a single tag in the frontend. Before the patch tag view 404's. afterwards doesn't.
Documentation Changes Required
None
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-21 17:25:46 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item
Resolves issue with both menu item for single tag and with module tags - popular.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28746.
Is the new release gonna published soon or should we patch the code?
Is the new release gonna published soon or should we patch the code?
See https://forum.joomla.org/viewtopic.php?p=3602147#p3602150 a new release will be published very soon.
Thanks a lot!
It might be more correct to remove this check.
I can’t understand why it is needed here.
https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/models/tag.php#L348
Sorry mixed up the versions. I was about to write 3.9.19 should the PR be targeted at.
I could have done it, but it’s already late in the evening and we won’t start making it.
And yes, the release has already been released.
Agree it is late here too and we took extra hours to make sure we get the release out very fast.
Here you can discuss the need for this 404.
In order not to do another pr just like that.
As said feel free to do the PR tomorrow on in the next days 3.9.19 should hopefully take some more time than 3.9.18 ;)
I have tested this item✅ successfully on 6c3f8a0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28746.