? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
21 Apr 2020

Summary of Changes

When a spacer field of class text is used to give information when creating some menu items, the display used is a 3 columns and text may be truncated.

This PR deletes these spacer fields and adds the necessary text as a description of the fieldset.
To prevent that description to be displayed as a block which may not be aligned to the fieldset fields, it is moved over the 3 columns layout and margin is modified to fit (margin test needs using npm).

Testing Instructions

Edit some items containing such spacers.
Example below is List All Categories Category tab.

Note:

  1. The Shared tab is already using a fieldset description, therefore its display is also modified to be shown on top of the 3 columns.
  2. The string JGLOBAL_SUBSLIDER_DRILL_CATEGORIES_LABEL does not need anymore the <br> in the value to force new lines which was useful in 3.x but unecessary in J4 with this PR.

Before patch

fieldset_spacer_before

After patch

fieldset_spacer_after

Documentation Changes Required

avatar infograf768 infograf768 - open - 21 Apr 2020
avatar infograf768 infograf768 - change - 21 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2020
Category Administration Language & Strings Templates (admin) Front End com_contact com_content com_newsfeeds com_tags Layout
avatar infograf768 infograf768 - change - 21 Apr 2020
The description was changed
avatar infograf768 infograf768 - edited - 21 Apr 2020
avatar Quy
Quy - comment - 21 Apr 2020

I have tested this item successfully on 401e24c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28737.

avatar Quy Quy - test_item - 21 Apr 2020 - Tested successfully
avatar richard67
richard67 - comment - 21 Apr 2020

I have tested this item successfully on 401e24c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28737.

avatar richard67 richard67 - test_item - 21 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 21 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28737.

avatar richard67 richard67 - change - 21 Apr 2020
Labels Added: ? ? ?
avatar zero-24 zero-24 - change - 22 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-22 08:41:32
Closed_By zero-24
Labels
avatar zero-24 zero-24 - close - 22 Apr 2020
avatar zero-24 zero-24 - merge - 22 Apr 2020
avatar zero-24
zero-24 - comment - 22 Apr 2020

Merged thanks ?

Add a Comment

Login with GitHub to post a comment