Joomla! Issue Tracker | Joomla! CMS #28734 - [4.0] - Respect the field limits for the asset table

? ?

Fixed in Code Base
25 Apr 2020
Medium
Build: 4.0-dev
# 28734
Diff
alikon:patch-109

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

alikon
20 Apr 2020

Pull Request for Issue #27673 (about the title length issue)

Summary of Changes

Respect the field limits for the asset table and give an error if not true

Testing Instructions

create a very long article title that is more than 100 chars

Expected result

warning if the article length is more higher than allowed

Actual result

error after saving

88fdcfc 20 Apr 2020

Respect the field limits for the asset table

7690eaf 20 Apr 2020

prevent title too long

alikon - open - 20 Apr 2020

alikon - change - 20 Apr 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Apr 2020

Category

⇒

Administration com_content Libraries

alikon - change - 20 Apr 2020

Labels

Added: ? ?

dcc277f 20 Apr 2020

1a5523d 20 Apr 2020

fix stupid cs

alikon - comment - 20 Apr 2020

cc: @Razzo1987

Razzo1987 - comment - 20 Apr 2020

I'm testing

Title of 50 char:
Maecenas cursus lectus at sollicitudin massa nunc1
Message: Article saved.
Alias: maecenas-cursus-lectus-at-sollicitudin-massa-nunc1
Alias: 50 char

Title of 100 char:
Duis luctus sit amet neque id mollis0 Praesent a mi ut augue mattis consectetur eget vel nulla amet1
Message: Article saved.
Alias: duis-luctus-sit-amet-neque-id-mollis0-praesent-a-mi-ut-augue-mattis-consectetur-eget-vel-nulla-amet1
Alias: 100 char

Title of 150 char:
Nam rhoncus0 neque id finibus auctor0 nibh urna sodales justo0 et ornare diam magna at nisl1 Nunc lobortis nec urna sit amet cursus1 Donec ut posuere1
Message: Article saved.
Alias: nam-rhoncus0-neque-id-finibus-auctor0-nibh-urna-sodales-justo0-et-ornare-diam-magna-at-nisl1-nunc-lobortis-nec-urna-sit-amet-cursus1-donec-ut-posuere1
Alias: 150 char

Title of 200 char:
Aenean rhoncus0 nunc quis volutpat mollis0 tellus leo mollis nisl0 ac convallis erat massa ac sem1 Curabitur suscipit lectus in aliquam feugiat1 Praesent consequat urna ac elit tincidunt0 ut volutpat1
Message: Article saved.
Alias: aenean-rhoncus0-nunc-quis-volutpat-mollis0-tellus-leo-mollis-nisl0-ac-convallis-erat-massa-ac-sem1-curabitur-suscipit-lectus-in-aliquam-feugiat1-praesent-consequat-urna-ac-elit-tincidunt0-ut-volutpat1
Alias: 200 char

title column in #__content table has 255 character limit. I think this value in https://github.com/joomla/joomla-cms/pull/28734/files/1a5523d935225ce001982ee330385cd1c2a9e163#diff-305a4ac6060381d6023e318496bb0b9e can be increased to 255

Razzo1987 - comment - 20 Apr 2020

Also...

Create the article with API:
POST BODY:

{
    "articletext": "Donec luctus0 nisi non dapibus venenatis0 diam mi congue justo0 in ultricies ante ipsum vitae nibh1 Suspendisse potenti1 Etiam placerat0 enim id vulputate commodo0 nisi lorem accumsan sem0 at varius sapien est vel est1 Duis sollicitudin nunc posuere1",
    "catid": 2,
    "language": "*",
    "metadesc": "",
    "metakey": "",
    "title": "Donec luctus0 nisi non dapibus venenatis0 diam mi congue justo0 in ultricies ante ipsum vitae nibh1 Suspendisse potenti1 Etiam placerat0 enim id vulputate commodo0 nisi lorem accumsan sem0 at varius sapien est vel est1 Duis sollicitudin nunc posuere1",
    "state": 0
}

RESPONSE BODY

{
    "errors": [
        {
            "title": ""
        }
    ]
}

The old message error was:

{
   "errors":[
      {
         "title":"Save failed with the following error: Data too long for column 'title' at row 1"
      }
   ]
}

880b2d1 21 Apr 2020

maxlength for title

f2b100d 21 Apr 2020

expand route field limits

joomla-cms-bot - change - 21 Apr 2020

Category

Administration com_content Libraries

⇒

Administration com_content SQL Installation Libraries

01920fe 21 Apr 2020

expand route field limits

joomla-cms-bot - change - 21 Apr 2020

Category

Administration com_content Libraries SQL Installation

⇒

Administration com_content SQL Installation Postgresql Libraries

058773f 21 Apr 2020

unneeded

a0e4c45 21 Apr 2020

use of StringHelper

99d4937 21 Apr 2020

extend route field

joomla-cms-bot - change - 21 Apr 2020

Category

Administration com_content Libraries SQL Installation Postgresql

⇒

SQL Administration com_admin com_content Installation Postgresql Libraries

265bcdd 21 Apr 2020

extend route field

alikon - comment - 21 Apr 2020

@Razzo1987 please retest

alikon - change - 21 Apr 2020

The description was changed

alikon - edited - 21 Apr 2020

adj9 - comment - 25 Apr 2020

I have not tested this item.

With just applying the patch and creating the article (len title 205) I have the following error:
Save failed with the following error: Data too long for column 'route' at row 1

The PR has 400 characters.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28734.}

adj9 - test_item - 25 Apr 2020 - Not tested

Razzo1987 - comment - 25 Apr 2020

We have tested from Patch Tester.
The MySQL doesn't change:

alikon - comment - 25 Apr 2020

yes there is an alter TABLE and cause of this you need to apply the ALTER from phpmyadmin if you are using patchtester
or
you can install the full pkg https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/28734/downloads/31429/Joomla_4.0.0-beta1-dev+pr.28734-Development-Full_Package.zip

adj9 - comment - 25 Apr 2020

In connection with what has been said before, after applying the PR, breaking the home dashboard, I check that all the icons do not have their position.

it is possible to scroll laterally with the arrows
eliminating the PR the anomaly persists, even with a logout / login.

The version of Safari I work with is 13.0.5.

Razzo1987 - comment - 25 Apr 2020

Title of 250 char:
Donec luctus0 nisi non dapibus venenatis0 diam mi congue justo0 in ultricies ante ipsum vitae nibh1 Suspendisse potenti1 Etiam placerat0 enim id vulputate commodo0 nisi lorem accumsan sem0 at varius sapien est vel est1 Duis sollicitudin nunc posuere1
Message: Article saved.
Alias: donec-luctus0-nisi-non-dapibus-venenatis0-diam-mi-congue-justo0-in-ultricies-ante-ipsum-vitae-nibh1-suspendisse-potenti1-etiam-placerat0-enim-id-vulputate-commodo0-nisi-lorem-accumsan-sem0-at-varius-sapien-est-vel-est1-duis-sollicitudin-nunc-posuere1
Alias: 250 char

Title of 300 char:
Lorem ipsum dolor sit amet0 consectetur adipiscing elit1 Proin porttitor magna enim0 sed feugiat purus tristique nec1 Morbi ante quam0 fermentum a interdum eget0 venenatis in arcu1 Pellentesque id est non dui imperdiet semper nec vitae ipsum1 Aliquam a porttitor metus1 Aliquam erat velit porta ante1
The title is trunc at 255 char:
Lorem ipsum dolor sit amet0 consectetur adipiscing elit1 Proin porttitor magna enim0 sed feugiat purus tristique nec1 Morbi ante quam0 fermentum a interdum eget0 venenatis in arcu1 Pellentesque id est non dui imperdiet semper nec vitae ipsum1 Aliquam a po
Message: Article saved.
Alias: lorem-ipsum-dolor-sit-amet0-consectetur-adipiscing-elit1-proin-porttitor-magna-enim0-sed-feugiat-purus-tristique-nec1-morbi-ante-quam0-fermentum-a-interdum-eget0-venenatis-in-arcu1-pellentesque-id-est-non-dui-imperdiet-semper-nec-vitae-ipsum1-aliquam-a-po
Alias: 255 char

It's OK. but I think is better if there is an alert

Create the article with API, Title 300 char:
POST BODY:

{
    "articletext": "Lorem ipsum dolor sit amet0 consectetur adipiscing elit1 Mauris tristique hendrerit elit0 quis malesuada ante1 Aenean sed orci sagittis0 suscipit nulla ac0 suscipit justo1 Donec pretium malesuada tempor1 In a orci eleifend0 pellentesque mi at0 rhoncus augue1 Sed eu dignissim nulla1 In viverra fusce1",
    "catid": 2,
    "language": "*",
    "metadesc": "",
    "metakey": "",
    "title": "Lorem ipsum dolor sit amet0 consectetur adipiscing elit1 Mauris tristique hendrerit elit0 quis malesuada ante1 Aenean sed orci sagittis0 suscipit nulla ac0 suscipit justo1 Donec pretium malesuada tempor1 In a orci eleifend0 pellentesque mi at0 rhoncus augue1 Sed eu dignissim nulla1 In viverra fusce1",
    "state": 0
}

RESPONSE BODY

{
    "errors": [
        {
            "title": "Save failed with the following error: Data too long for column 'title' at row 1"
        }
    ]
}

Perfect!

Razzo1987 - comment - 25 Apr 2020

I have tested this item ✅ successfully on 265bcdd

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28734.}

Razzo1987 - test_item - 25 Apr 2020 - Tested successfully

faustonenci - comment - 25 Apr 2020

I have tested this item ✅ successfully on 265bcdd

good

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28734.}

faustonenci - test_item - 25 Apr 2020 - Tested successfully

alikon - change - 25 Apr 2020

Title

…

[4.0]~~[RFC]~~ - Respect the field limits for the asset table

[4.0] - Respect the field limits for the asset table

alikon - edited - 25 Apr 2020

alikon - change - 25 Apr 2020

Status

Pending

⇒

Ready to Commit

alikon - comment - 25 Apr 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28734.}

wilsonge - change - 25 Apr 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-04-25 18:28:38
Closed_By		⇒	wilsonge
Labels	Added: ? Removed: ?

wilsonge - close - 25 Apr 2020

wilsonge - merge - 25 Apr 2020

wilsonge - comment - 25 Apr 2020

Thanks!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#28734] - [4.0] - Respect the field limits for the asset table

Summary of Changes

Testing Instructions

Expected result

Actual result

Add a Comment