[#28725] - [4.0] Get rid of the not used gravatar form the webauthn plugin.
- Fixed in Code Base
- 19 May 2020
- Medium
- Build: 4.0-dev
- # 28725
- Diff
- zero-24:webauthn_gravater
User tests: Successful: Unsuccessful:
Summary of Changes
Get rid of the not used gravatar from the webauthn plugin.
Testing Instructions
- apply this patch
- setup webauthn
- confirm login works as expected.
Expected result
We don't use the image from gravatar so let's not try to get one.
Actual result
We try to get an image from gravatar that we don't use anyway.
Documentation Changes Required
None
cc @wilsonge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
Fixed thanks.
This is one of these awkward ones - do we need a way to let people add support generically for avatars so they can use them in their templates? (more than happy to remove the gravatar specific stuff)
do we need a way to let people add support generically for avatars so they can use them in their templates?
Why should we? Right now the mail for one account would be the same for all tokens so it is quite useless to have a avatar (based on the users email) right?
To me it does not make sense to have a avatar there at all. But for sure can be implemented later when someone found a use case.
But up to you to decide on. Right now it is to me just an data leak leaking the users eMail to an external service without out us even using what is returned so to me this code here should not be included in the core package.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-05-19 18:47:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@zero-24 I've corrected spelling in title and description ("gravater" => "gravatar"). One thing is not clear to me. In section "Actual result" you write: "We dont try to get an image from gravatar that we dont use anyway.". Shouldn't that be "We try to get an image from gravatar that we dont use anyway.", i.e. without the "dont"? "Actual result" should describe what happens without this PR.