? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
18 Apr 2020

Pull Request for Issue #28717 .

Summary of Changes

removed join with the workflows table

Testing Instructions

#28717

Expected result

works as admin module

Actual result

don't work

avatar alikon alikon - open - 18 Apr 2020
avatar alikon alikon - change - 18 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2020
Category Modules Front End
avatar richard67
richard67 - comment - 18 Apr 2020

I have tested this item successfully on 60f1572


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28723.

avatar richard67 richard67 - test_item - 18 Apr 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 18 Apr 2020

I have tested this item successfully on 60f1572


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28723.

avatar jwaisner jwaisner - test_item - 18 Apr 2020 - Tested successfully
avatar jwaisner jwaisner - change - 18 Apr 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 18 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28723.

avatar infograf768 infograf768 - change - 19 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-19 07:36:40
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 19 Apr 2020
avatar infograf768 infograf768 - merge - 19 Apr 2020
avatar infograf768
infograf768 - comment - 19 Apr 2020

tks

avatar brianteeman
brianteeman - comment - 19 Apr 2020

I am not convinced simply removing the workflow stuff is correct - it must have been put there for a reason

avatar richard67
richard67 - comment - 19 Apr 2020

@brianteeman As far as I remember the workflow stuff here was the remainder of an intermediate phase of development which was later rolled back so that state column of the #__content table was used again, but I might be wrong, so it would be cool if @bembelimen could have a look and comment.

avatar bembelimen
bembelimen - comment - 19 Apr 2020

The state column is still there for B/C reasons, but is general ignored. I don't care, if the clean version (join over WF) or the state-version is used. I guess the state field will never disappear, so it doesn't matter.

Add a Comment

Login with GitHub to post a comment