User tests: Successful: Unsuccessful:
Pull Request for Issue # .
No issue created (yet)
Changed lint
related files as well as one config file in /
dir
Status | New | ⇒ | Pending |
Category | ⇒ | Repository |
Title |
|
Makes a changelog.md for this project sense? Who will maintain that consistently?
We don't need a changelog. We used to have a manually created one but github makes that redundant which you will see in the readme and it points to
thank you for your 1st contribution
but please fill all the template items
otherwise it will be very difficult to understand your pull request
thanks in advance
done
Makes a changelog.md for this project sense? Who will maintain that consistently?
Is it difficult to create GitHubAction for this?
I dont see the need for another changelog
@AnnaLisik In order for proper testing to take place can you update the issue detail with testing instructions?
@AnnaLisik Thanks for your first contribution. Unfortunately it is wrong, see the diverse review comments above. Happened to me, too, in past, when I was a new contributor. Don't give up, maybe next time it will be better. The different code style rules might be indeed a bit confusing if you see them for the first time, but they make sense and work pretty well right now.
Status | Pending | ⇒ | Expected Behaviour |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-20 20:06:59 |
Closed_By | ⇒ | richard67 |
Closing as expected behavior.
@AnnaLisik Thanks for your first contribution. Unfortunately it is wrong, see the diverse review comments above. Happened to me, too, in past, when I was a new contributor. Don't give up, maybe next time it will be better. The different code style rules might be indeed a bit confusing if you see them for the first time, but they make sense and work pretty well right now.
Many thanks for this. Really appreciate. To be honest Im well suprised, as I didnt suspect someone here to be as friendly and warm as you. Thanks again and well done.
We are a community of volunteers, and we need every helping hand, and we know it is not easy to start with contributing, so we try to advise and encourage not to give up. I am sure other contributors are friendly, too.
We are a community of volunteers, and we need every helping hand, and we know it is not easy to start with contributing, so we try to advise and encourage not to give up. I am sure other contributors are friendly, too.
Thanks for this :) Can you point me to the web resource that describe how to contribute? I use many web-software (Joomla included) and thought that it'd be nice not only to take, but to give sth from me. Like new code, etc.
We always need people who test pull requests by other people: https://docs.joomla.org/Testing_Joomla!_patches.
Things you need to prepare before you can develop code:
Here a good starting page which brings links to these and other documentation for contributors together: https://docs.joomla.org/Portal:Joomla!_Code_Contributors.
We always need people who test pull requests by other people: https://docs.joomla.org/Testing_Joomla!_patches.
Things you need to prepare before you can develop code:
- https://docs.joomla.org/Setting_up_your_workstation_for_Joomla_development
- For Joomla 4 in addition: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment
Here a good starting page which brings links to these and other documentation for contributors together: https://docs.joomla.org/Portal:Joomla!_Code_Contributors.
Many thanks for this. Will read and try something
thank you for your 1st contribution
but please fill all the template items
otherwise it will be very difficult to understand your pull request
thanks in advance