Pending

User tests: Successful: Unsuccessful:

avatar AnnaLisik
AnnaLisik
17 Apr 2020

Pull Request for Issue # .
No issue created (yet)

Summary of Changes

Changed lint related files as well as one config file in / dir

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar AnnaLisik AnnaLisik - open - 17 Apr 2020
avatar AnnaLisik AnnaLisik - change - 17 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2020
Category Repository
avatar AnnaLisik AnnaLisik - change - 17 Apr 2020
Title
Anna lisik branch
Some small changes
avatar AnnaLisik AnnaLisik - edited - 17 Apr 2020
avatar alikon
alikon - comment - 17 Apr 2020

thank you for your 1st contribution
but please fill all the template items
otherwise it will be very difficult to understand your pull request
thanks in advance

avatar ReLater
ReLater - comment - 17 Apr 2020

Makes a changelog.md for this project sense? Who will maintain that consistently?

avatar brianteeman
brianteeman - comment - 17 Apr 2020

We don't need a changelog. We used to have a manually created one but github makes that redundant which you will see in the readme and it points to

https://github.com/joomla/joomla-cms/commits/staging

avatar AnnaLisik AnnaLisik - change - 17 Apr 2020
The description was changed
avatar AnnaLisik AnnaLisik - edited - 17 Apr 2020
avatar AnnaLisik
AnnaLisik - comment - 17 Apr 2020

thank you for your 1st contribution
but please fill all the template items
otherwise it will be very difficult to understand your pull request
thanks in advance

done

avatar AnnaLisik
AnnaLisik - comment - 17 Apr 2020

Makes a changelog.md for this project sense? Who will maintain that consistently?

Is it difficult to create GitHubAction for this?

avatar brianteeman
brianteeman - comment - 17 Apr 2020

I dont see the need for another changelog

avatar jwaisner
jwaisner - comment - 17 Apr 2020

@AnnaLisik In order for proper testing to take place can you update the issue detail with testing instructions?

avatar richard67
richard67 - comment - 20 Apr 2020

@AnnaLisik Thanks for your first contribution. Unfortunately it is wrong, see the diverse review comments above. Happened to me, too, in past, when I was a new contributor. Don't give up, maybe next time it will be better. The different code style rules might be indeed a bit confusing if you see them for the first time, but they make sense and work pretty well right now.

avatar richard67 richard67 - change - 20 Apr 2020
Status Pending Expected Behaviour
Closed_Date 0000-00-00 00:00:00 2020-04-20 20:06:59
Closed_By richard67
avatar richard67 richard67 - close - 20 Apr 2020
avatar richard67
richard67 - comment - 20 Apr 2020

Closing as expected behavior.

avatar AnnaLisik
AnnaLisik - comment - 21 Apr 2020

@AnnaLisik Thanks for your first contribution. Unfortunately it is wrong, see the diverse review comments above. Happened to me, too, in past, when I was a new contributor. Don't give up, maybe next time it will be better. The different code style rules might be indeed a bit confusing if you see them for the first time, but they make sense and work pretty well right now.

Many thanks for this. Really appreciate. To be honest Im well suprised, as I didnt suspect someone here to be as friendly and warm as you. Thanks again and well done.

avatar richard67
richard67 - comment - 21 Apr 2020

We are a community of volunteers, and we need every helping hand, and we know it is not easy to start with contributing, so we try to advise and encourage not to give up. I am sure other contributors are friendly, too.

avatar AnnaLisik
AnnaLisik - comment - 21 Apr 2020

We are a community of volunteers, and we need every helping hand, and we know it is not easy to start with contributing, so we try to advise and encourage not to give up. I am sure other contributors are friendly, too.

Thanks for this :) Can you point me to the web resource that describe how to contribute? I use many web-software (Joomla included) and thought that it'd be nice not only to take, but to give sth from me. Like new code, etc.

avatar richard67
richard67 - comment - 21 Apr 2020

We always need people who test pull requests by other people: https://docs.joomla.org/Testing_Joomla!_patches.

Things you need to prepare before you can develop code:

Here a good starting page which brings links to these and other documentation for contributors together: https://docs.joomla.org/Portal:Joomla!_Code_Contributors.

avatar AnnaLisik
AnnaLisik - comment - 22 Apr 2020

We always need people who test pull requests by other people: https://docs.joomla.org/Testing_Joomla!_patches.

Things you need to prepare before you can develop code:

Here a good starting page which brings links to these and other documentation for contributors together: https://docs.joomla.org/Portal:Joomla!_Code_Contributors.

Many thanks for this. Will read and try something

Add a Comment

Login with GitHub to post a comment