Feeling Lucky
?
[#28692] - [4.0] Replace 25% & 50% width inline styles with respective classes
- Fixed in Code Base
- 17 Apr 2020
- Medium
- Build: 4.0-dev
- # 28692
- Diff
- Quy:w-25-50
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Redo of #27344 to fix conflicts and do incremental PRs for easy testing.
Thanks @chang-zhao for the initial PR.
Summary of Changes
Replace width inline styles with classes.
w-25 and w-50 are Bootstrap sizing classes so no need to create these classes.
Testing Instructions
Code review.
or
Log in to administration.
No visual changes in the following:
See Logged-in Users module.
See System > System Information > System Information tab
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_content com_contenthistory com_templates com_users Modules |
Quy
- comment
- 15 Apr 2020
Fixed. Thanks.
jwaisner
- comment
- 16 Apr 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692.
ChristineWk
- comment
- 16 Apr 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 16 Apr 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28692.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-17 06:26:49 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 17 Apr 2020
Thanks
What is the benefit of replacing style width with classes?