? ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
13 Apr 2020

Pull Request for Issue # .

Redo of PR #28675 .

Thanks @infograf768 for the fix.

Summary of Changes

Same code exists for menu items. Was missing in category model.

Testing Instructions

Create multilingual site using sample data.
Edit a category tagged to a language.
Click on the Associations toolbar button
Instead of displaying the side by side of com_associations, it just saves the category and redirects to the manager.

Patch and test again.

Expected result

Associations side-by-side view opened.

Actual result

Redirected to the categories manager.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 13 Apr 2020
avatar richard67 richard67 - change - 13 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2020
Category Administration com_categories
avatar infograf768
infograf768 - comment - 13 Apr 2020

Ok to go.

avatar richard67 richard67 - change - 13 Apr 2020
The description was changed
avatar richard67 richard67 - edited - 13 Apr 2020
avatar infograf768
infograf768 - comment - 13 Apr 2020

I have tested this item successfully on 9ab9639


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28678.

avatar infograf768 infograf768 - test_item - 13 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 13 Apr 2020
Priority Medium Urgent
Labels Added: ? ?
avatar richard67
richard67 - comment - 13 Apr 2020

@alikon Could you test? Is the same as JM's PR before.

avatar astridx
astridx - comment - 13 Apr 2020

I have tested this item successfully on 9ab9639


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28678.

avatar astridx astridx - test_item - 13 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 13 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28678.

avatar astridx
astridx - comment - 13 Apr 2020
  1. The button does not work correctly before I applied the patch.
    Articles   Modifier la catégorie   test   Administration
    A click forwarded me not to the associations component.

  2. $ git fetch origin pull/28678/head:staging-fix-associations-button-for-categories-edit

  3. $ git checkout staging-fix-associations-button-for-categories-edit

  4. Now the button forwarded me to the correct page.
    Associations multilingues   Modifier les associations  Articles  gt  Catégories    test   Administration

avatar richard67
richard67 - comment - 13 Apr 2020

@astridx Seems you could be a good candidate for updating our documentation on using git and github ?

avatar HLeithner HLeithner - change - 13 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-13 16:35:44
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 13 Apr 2020
avatar HLeithner HLeithner - merge - 13 Apr 2020
avatar HLeithner
HLeithner - comment - 13 Apr 2020

Thanks

Add a Comment

Login with GitHub to post a comment