Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28675] - [3.9] Associations Toolbar button broken when editing category

? ? ? ? ? Failure

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
13 Apr 2020

Summary of Changes

Same code exists for menu items. Was missing in category model

Testing Instructions

Create multilingual site using sample data.
Edit a category tagged to a language.
Click on the Associations toolbar button
Instead of displaying the side by side of com_associations, it just saves the category and redirects to the manager.

Patch and test again.

avatar infograf768 infograf768 - open - 13 Apr 2020
avatar infograf768 infograf768 - change - 13 Apr 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2020
Category ⇒ Administration com_categories
avatar infograf768 infograf768 - change - 13 Apr 2020
Title
…
Associations Toolbar button broken when editing category
[3.10] Associations Toolbar button broken when editing category
avatar infograf768 infograf768 - edited - 13 Apr 2020
avatar infograf768
infograf768 - comment - 13 Apr 2020

@HLeithner
This is also for staging, i.e 3.9.17

Please merge urgent in both

avatar infograf768 infograf768 - change - 13 Apr 2020
Title
…
[3.10] Associations Toolbar button broken when editing category
[3.10 & Staging] Associations Toolbar button broken when editing category
avatar infograf768 infograf768 - edited - 13 Apr 2020
avatar alikon
alikon - comment - 13 Apr 2020

I have tested this item ✅ successfully on 279afae

on staging

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28675.

avatar alikon alikon - test_item - 13 Apr 2020 - Tested successfully
avatar HLeithner HLeithner - change - 13 Apr 2020
Title
…
[3.10 & Staging] Associations Toolbar button broken when editing category
[3.9] Associations Toolbar button broken when editing category
avatar HLeithner HLeithner - edited - 13 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2020
Category Administration com_categories ⇒ Unit Tests Repository Administration com_categories com_joomlaupdate com_languages com_menus Language & Strings
avatar HLeithner
HLeithner - comment - 13 Apr 2020

can you rebase it on staging please? then it will be merged into 3.10 on release.

avatar richard67
richard67 - comment - 13 Apr 2020

I have tested this item ✅ successfully on 279afae

Tested with success on staging.

@HLeithner If @infograf768 can't rebase it for some reason, maybe you can just cherry pick his commits into staging?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28675.

avatar richard67 richard67 - test_item - 13 Apr 2020 - Tested successfully
avatar richard67
richard67 - comment - 13 Apr 2020

@infograf768 I've suggested a little CS fix (unnecessary empty line removed).

avatar wilsonge wilsonge - change - 13 Apr 2020
Labels Added: ? ? ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2020
Category Administration com_categories Unit Tests Repository com_joomlaupdate com_languages com_menus Language & Strings ⇒ Administration com_categories
avatar infograf768
infograf768 - comment - 13 Apr 2020

changed branch but some issues apparently

avatar richard67 richard67 - change - 13 Apr 2020
Labels Removed: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2020
Category Administration com_categories ⇒ Unit Tests Repository Administration com_categories com_joomlaupdate com_languages com_menus Language & Strings
avatar infograf768
infograf768 - comment - 13 Apr 2020

This is now badly broken. Closing

avatar infograf768 infograf768 - close - 13 Apr 2020
avatar infograf768 infograf768 - change - 13 Apr 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-04-13 13:43:29
Closed_By ⇒ infograf768
Labels Added: ? ?
avatar richard67
richard67 - comment - 13 Apr 2020

New PR for staging is #28678 .

Add a Comment

Login with GitHub to post a comment