? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
12 Apr 2020

Pull Request for Issue #28665 .

Summary of Changes

Improve padding around text in quickicons

Testing Instructions

Apply the patch don't forget to build the css with npm.
Have a look on the quickicons on differents screens.

Expected result

All texts should have some padding.

Actual result

see the issue

Documentation Changes Required

no

avatar chmst chmst - open - 12 Apr 2020
avatar chmst chmst - change - 12 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2020
Category Administration Templates (admin) Layout
avatar chmst chmst - change - 12 Apr 2020
Title
Improve text padding in quickicons
[4.0] Improve text padding in quickicons
Labels Added: ? ? NPM Resource Changed
avatar chmst chmst - edited - 12 Apr 2020
avatar chmst chmst - change - 12 Apr 2020
The description was changed
Priority Medium Low
avatar chmst chmst - edited - 12 Apr 2020
avatar chmst chmst - change - 12 Apr 2020
Labels Removed: ? NPM Resource Changed
avatar richard67
richard67 - comment - 12 Apr 2020

I have tested this item successfully on f960459


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28668.

avatar richard67 richard67 - test_item - 12 Apr 2020 - Tested successfully
avatar coolcat-creations
coolcat-creations - comment - 12 Apr 2020

I have tested this item successfully on f960459

Successful for the mentioned Icon in the PR, could not test with 3rd party extensions because I am constantly thrown out of the backend since applying the patch. I am sure it has nothing to do with each other since you only worked on the scss and classes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28668.

avatar coolcat-creations coolcat-creations - test_item - 12 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 12 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 12 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28668.

avatar richard67
richard67 - comment - 12 Apr 2020

I've also checked that the quickicons still work by faking a Joomla Update, and Extension Update and an Urgent Privacy Request.

avatar wilsonge wilsonge - close - 12 Apr 2020
avatar wilsonge wilsonge - merge - 12 Apr 2020
avatar wilsonge wilsonge - change - 12 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-12 17:16:23
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 12 Apr 2020

Thanks guys!

Add a Comment

Login with GitHub to post a comment