?
avatar coolcat-creations
coolcat-creations
12 Apr 2020

What needs to be fixed

grafik

The spacing of the text in privacy requests is bit to low, all the spacings should be equal and also the icon positioning should be matching.

Thank you!

avatar coolcat-creations coolcat-creations - open - 12 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Apr 2020
avatar brianteeman
brianteeman - comment - 12 Apr 2020

Whoever works on this please remember that changing the actual text to fit is not a solution as it will be different in every language

avatar adj9
adj9 - comment - 12 Apr 2020

With Joomla! 4 beta-1 installed on 9th April, the spacings are like this.

Schermata 2020-04-12 alle 13 23 35

By varying the size of the browser, the block size varies.
I use safari 13.0.5.

avatar coolcat-creations
coolcat-creations - comment - 12 Apr 2020

@adj9 at 13" screen using firefox the result is like described in the initial issue.
In your screen there is a second template issue, the 3rd party icons should render with the same width like the core icons and also vertically aligned.

avatar ReLater
ReLater - comment - 12 Apr 2020

Sacrilegious comment: Why must these boxes have the same heights in any circumstance? If an information is longer it's more important one can read it instead of any esthetic quality.

Current behavior:

12-04-_2020_14-22-09

OK:

12-04-_2020_14-21-34

avatar coolcat-creations
coolcat-creations - comment - 12 Apr 2020

While your second example is still bit odd because the text does not use as much space as it could it's better than before. Not quite sure if the different height are solveable in css, an still keeping it dynamic.
In your example the Kunena Icon is also to small in comparsion to the core icons.

Also I don't know if "Update Checks" is the right headline here. Are Privacy Requests really "Updates" ?

avatar chmst
chmst - comment - 12 Apr 2020

Please test #28668 for the padding.

I agree that the name of the box could be "urgent notification" or someting similar, but this is question to a native speaker.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28665.

avatar ReLater
ReLater - comment - 12 Apr 2020

While your second example is still bit odd because the text does not use as much space

I added <br> in the text just to demonstrate what happens if you have more than 3 lines.

avatar ReLater
ReLater - comment - 12 Apr 2020

Not quite sure if the different height are solveable in css

It is. Otherwise I couldn't demonstrate it above. I changed the CSS in browser inspector. Therefore it should be also possible in SCSS/CSS files.

avatar chmst
chmst - comment - 12 Apr 2020

@ReLater I've made a PR #28668 - would nice to get a test?

@coolcat-creations could you open an own issue for the name of the box? I fully agree with this but these are two different topics


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28665.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-04-12 15:23:01
Closed_By joomla-cms-bot
avatar chmst chmst - change - 12 Apr 2020
Closed_By joomla-cms-bot chmst
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2020
avatar joomla-cms-bot
joomla-cms-bot - comment - 12 Apr 2020

Set to "closed" on behalf of @chmst by The JTracker Application at issues.joomla.org/joomla-cms/28665

avatar chmst
chmst - comment - 12 Apr 2020

Closed as we have a PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28665.

avatar coolcat-creations
coolcat-creations - comment - 12 Apr 2020

@adj9 Where did you find the akeeba Version to install on J4 ? I want to test the patch with 3rd party too. Thank you

avatar brianteeman
brianteeman - comment - 12 Apr 2020

akeebabackup.com

Add a Comment

Login with GitHub to post a comment