? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
11 Apr 2020

Pull Request for Issue #28615 (comment) .

Summary of Changes

Fixes some layout issues on com_menu and com_assosiations.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Check searchtools are displaying correctly.

@infograf768

avatar ciar4n ciar4n - open - 11 Apr 2020
avatar ciar4n ciar4n - change - 11 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2020
Category Administration com_associations com_menus Templates (admin)
avatar Razzo1987
Razzo1987 - comment - 11 Apr 2020

I have tested this item successfully on dff34bc

Yes, now is inline
immagine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.
avatar Razzo1987 Razzo1987 - test_item - 11 Apr 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Apr 2020

@ciar4n The clear button still has same color as the filter options button when a filter is applied. Was the 2nd thing which @infograf768 remarked in his comment in the other PR. Should that be fixed here, too? The inline display of the filter options is ok now, as the previlus tester remarked.

avatar adj9
adj9 - comment - 11 Apr 2020

I have tested this item successfully on dff34bc

with the patch I have the voices horizontally.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

avatar adj9 adj9 - test_item - 11 Apr 2020 - Tested successfully
avatar ciar4n ciar4n - change - 11 Apr 2020
Labels Added: ?
avatar ciar4n
ciar4n - comment - 11 Apr 2020

@richard67 Thx. Yes that can be added here. Color added to clear button with 1700a92

image

avatar richard67
richard67 - comment - 11 Apr 2020

Will test in a few minutes. @Razzo1987 Could you test again? This time not only if the search filter drop downs are properly inlined but also if the color of the "Clear" button for the filter is like shown in the previous comment? Thanks in advance.

avatar richard67
richard67 - comment - 11 Apr 2020

I have tested this item successfully on 1700a92

Both of the issue mentioned in #28615 (comment) are fixed now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

avatar richard67 richard67 - test_item - 11 Apr 2020 - Tested successfully
avatar alikon
alikon - comment - 11 Apr 2020

I have tested this item successfully on 1700a92


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

avatar alikon alikon - test_item - 11 Apr 2020 - Tested successfully
avatar alikon alikon - change - 11 Apr 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 11 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

avatar wilsonge wilsonge - change - 11 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 21:05:24
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar wilsonge wilsonge - merge - 11 Apr 2020
avatar wilsonge
wilsonge - comment - 11 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment