PR-4.0-dev RTC

Pending

Pull Request for # 28628

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
10 Apr 2020

Pull Request for Issue #28628.

Summary of Changes

Corrects dates in query when saving featured article.

Testing Instructions

Write an article, set is published and featured.
Make a Featured blog.

Expected result

The article is visible

Actual result

The article is not visible in the featured blog, but in a normal categoy blog

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 10 Apr 2020
avatar SharkyKZ SharkyKZ - change - 10 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2020
Category Administration com_content
avatar SharkyKZ SharkyKZ - change - 10 Apr 2020
Rel_Number 28628
Relation Type Pull Request for
Labels Added: PR-4.0-dev
avatar richard67
richard67 - comment - 10 Apr 2020

@SharkyKZ Drone reports PHPCS errors. Could you fix them?

e753b00 11 Apr 2020 avatar SharkyKZ CS
avatar Harmageddon
Harmageddon - comment - 11 Apr 2020

I have tested this item successfully on e753b00

Works for me. For future testers: Note that the problem only occurs when creating a new article on an installation that doesn't include this patch. If you once have saved the article with a feature up date or with this PR, it will always correctly stay featured (unless you unfeature it), because it is correctly saved in the database.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28632.

avatar Harmageddon Harmageddon - test_item - 11 Apr 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Apr 2020

Appveyor failure is a known issue not related to this PR, fix is in progress.

Drone PHPCS is ok now, other failure was maybe the randomly occuring issue, also not related to this PR ... just restarted drone, maybe we are lucky now.

avatar richard67
richard67 - comment - 11 Apr 2020

I have tested this item successfully on e753b00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28632.

avatar richard67 richard67 - test_item - 11 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 11 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28632.

avatar wilsonge wilsonge - change - 11 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-11 21:05:02
Closed_By wilsonge
Labels Added: RTC
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar wilsonge wilsonge - merge - 11 Apr 2020
avatar wilsonge
wilsonge - comment - 11 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment