No Code Attached Yet Information Required bug
avatar ciar4n
ciar4n
10 Apr 2020

Elements like alerts appear to import styling upstream from the custom-element repo and then proceed to mostly override that styling locally. The result is at least twice as much CSS as is required.

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss#L12

Styling should be applied upstream on the custom-elements repo OR remove the import and style locally.. not both.

avatar ciar4n ciar4n - open - 10 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 Apr 2020
avatar brianteeman
brianteeman - comment - 10 Apr 2020

agree 100% it should be one or the other and not both

avatar ciar4n
ciar4n - comment - 10 Apr 2020

One option.... #28627

avatar ciar4n
ciar4n - comment - 10 Apr 2020

Turns out there is 2 different styles of alert. The second style overriding the first depending on where it is rendered. ?

So regarding the alerts, it is not as bad but still weird.

avatar wilsonge
wilsonge - comment - 10 Apr 2020

Do we really need two styles of alert. I have to admit the stuff in the sample data install that is inline does look a bit weird. But feels like there should be a better way of handling it somehow

avatar brianteeman
brianteeman - comment - 10 Apr 2020

Well we do need inline alerts to satisfy #27391

avatar Hackwar Hackwar - change - 21 Feb 2023
Labels Added: No Code Attached Yet bug
Removed: ?
avatar Hackwar Hackwar - labeled - 21 Feb 2023
avatar brianteeman
brianteeman - comment - 24 Feb 2023

Is this a duplicate of #22842

avatar Quy Quy - change - 26 Feb 2023
Labels Added: Information Required
avatar Quy Quy - labeled - 26 Feb 2023
avatar Hackwar Hackwar - change - 26 Nov 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-11-26 17:55:08
Closed_By Hackwar
avatar Hackwar Hackwar - close - 26 Nov 2024
avatar Hackwar
Hackwar - comment - 26 Nov 2024

I'm deciding that this is a duplicate of #22842 and thus will close this ticket.

Add a Comment

Login with GitHub to post a comment