[#28618] - Sync isSSLConnection function to framework
- Closed
- 9 Jan 2022
- Medium
- Build: staging
- # 28618
- Diff
- HLeithner:fix/isssl
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15436 .
Summary of Changes
Complete the TLS detection already done in parts of the CMS if a reverse proxy only provide the HTTP_X_FORWARDED_PROTO environment variable.
This PR copies the framework function into the CMS classes.
Testing Instructions
Install Joomla behind a proxy that only support HTTP_X_FORWARDED_PROTO === 'https' to test.
Also test all other variation for URL generation, simplest location should be the RSS feed.
All Links should have the same http/s protocol like the initial request.
You also can simulate this by setting
$_SERVER['HTTP_X_FORWARDED_PROTO'] = 'https'
in the index.php.
Do the same in a separated test for HTTPS = 'on'; and HTTPS = 'off';
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
Thanks I already noticed it in the tests, I'm fixing it at the moment.
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-09 11:39:33 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
Removed: ? ? |
||
You don’t have
$this->inputin the browser class, be careful with untested copy/paste.