User tests: Successful: Unsuccessful:
This PR rewrites the CSS for searchtools. The current CSS is a bit of a mess and hugely excessive. Here we remove 300+ lines of SCSS. Style changes are minimal but in general, should look the same.
Apply this patch and run node build.js --compile-css
for updating the changed SCSS. Check searchtools are displaying correctly.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Front End com_config Layout |
Labels |
Added:
?
|
The reason for the suggestion is to make all the selects in the searchtools have a similar look
The reason for the suggestion is to make all the selects in the searchtools have a similar look
Your suggestion makes sense. I think all chevrons throughout the UI should look the same, so whatever that is, lets replicate everywhere,
Agreed. I tried with the chevrons, border-radius, focus etc but its a bit beyond me to do it as efficiently as you.
Note: the xtd are also using searchtools in cassiopea.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-09 13:11:25 |
Closed_By | ⇒ | wilsonge |
Merging this as a start point. If you could review the chevrons to be consistent that would be excellent.
Note: the xtd are also using searchtools in cassiopea.
I create a separate PR for the frontend. Any idea why this is separate CSS?
@wilsonge Merging this has broken npm ci:
Error: Undefined variable: "$white".
on line 34 of administrator/templates/atum/scss/system/searchtools/searchtools.scss
>> background-color: $white;
----------------------^
Segmentation fault (core dumped)
The reason is that this PR here has removed the import for variables.scss from the top of the searcthools.scss file but still uses a variable $white
.
@ciar4n Please advise so I can make PR, or please make PR yourself: Shall we add back the import of "../../variables" or shall we change the variable to a hard-coded value?
@richard67 Replacing $white
with white
should be fine. That or add back in the variables import. I'll create a PR later if not fixed in the meantime (afk).
@richard67 PR.. #28619
Anyone have any idea how to display the 'searchtools' in the frontend?
when you are editing an article in the frontend click on one of the xtd-editor buttons eg menu link
Thanks
It also gives same oddity when using the menus xtd
reverting the PR solves the issues.
Thx @infograf768. #28644 should resolve these issues.
Can you look at some of the changes I made here #28461
Obviously not the code but the results