[#28607] - [4.0] Refactor toolbar styling
- Fixed in Code Base
- 8 Apr 2020
- Medium
- Build: 4.0-dev
- # 28607
- Diff
- ciar4n:less-subhead
User tests: Successful: Unsuccessful:
This PR refactors the styling for the toolbar buttons. The current CSS is a bit of a mess and hugely excessive. Here we remove 300+ lines of SCSS. Style changes are minimal but in general, should look neater and be more reliable.
Styling fully using logical properties so no RTL CSS required. Out of the box RTL.
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Layout |
| Labels |
Added:
?
|
||
should this not have rounded corners on the right?
Dropdowns seem to be missing space between the icon and the text
Before
Now
other than those two small issues it looks great in ltr and rtl
Dropdowns seem to be missing space between the icon and the text
Ty. Should be ok now.
dropdowns are great now. just the rounded corner to do
should this not have rounded corners on the right?
It appears only Firefox currently supporting logical properties on border-radius. Changed to static properties so should be ok now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28607.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-08 11:30:37 |
| Closed_By | ⇒ | wilsonge |
LGTM Thanks!
Thank You!!!