? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
6 Apr 2020

Pull Request for Issue #28546 .

Also removed some redundant rules ( #28586 & #28585).

Summary of Changes

Implements some logical properties to reduce on RTL CSS.

Testing Instructions

Apply this patch and run node build.js --compile-css to update SCSS. Check RTL styling.

avatar ciar4n ciar4n - open - 6 Apr 2020
avatar ciar4n ciar4n - change - 6 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2020
Category Administration Templates (admin)
avatar wilsonge
wilsonge - comment - 6 Apr 2020

@infograf768 can you test this please. If this works it will make maintaining RTL much easier.

avatar ciar4n ciar4n - change - 6 Apr 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 7 Apr 2020

I have tested this item successfully on eb0d8bb

There are many changes and I'm not sure I tested all, but for what I tested it looks fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28589.

avatar infograf768 infograf768 - test_item - 7 Apr 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 7 Apr 2020

My tests were done with Firefox Macintosh

avatar ciar4n
ciar4n - comment - 7 Apr 2020

Thank you @infograf768

avatar wilsonge
wilsonge - comment - 8 Apr 2020

Think the toolbar cleanup you did conflicted here. If you fix the conflicts happy to get this in

avatar ciar4n
ciar4n - comment - 8 Apr 2020

Sorted. Once this is merged I will continue a cleanup across admin css.

avatar wilsonge wilsonge - change - 8 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-08 15:41:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Apr 2020
avatar wilsonge wilsonge - merge - 8 Apr 2020
avatar wilsonge
wilsonge - comment - 8 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment