[#28587] - [4.0] Fixing smartsearch issue with some multibytes characters
- Closed
- 8 Apr 2020
- Medium
- Build: 4.0-dev
- # 28587
- Diff
- infograf768:4.0_finder_collations
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for remaining part of Issue #28493
Summary of Changes
Changing 3 tables ( finder_terms, finder_tokens and finder_aggregates) to the utf8mb4_bin collation, including in the specific J4 update.sql
Testing Instructions
See below because of drone sensibility. GRRR!!
Result
Result OK and hightlighting is correct.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin com_finder Installation |
This could be a solution and the case insensitivity wouldn't be a problem, but I'm still looking at the side effects.
instead of changing the collation of the whole table i'd prefer to change the collation of the single fields involved....
Could you list the columns which need binary collation?
In this case I welcome patches to my branch or create a new PR and I will delete this. No ego here
instead of changing the collation of the whole table i'd prefer to change the collation of the single fields involved....
I just see in case of #__finder_terms_common we also did binary collation for the complete table when we implemented the utf8mb4 conversion in J3. The only column affected by this in addition to the term column was the language column in that case. But that isn't really a problem.
So it could be easier to do it for the complete tables like here in this PR now.
@infograf768 Could you test if PR #28592 works, too?
Testing instructions
Patch and make a clean install.
Create and publish an article which will contain
Chinese: 不能创建文件
Greek: Εγκατάσταση Γλωσσών
German: Europäer
French: être noël
Simple chinese: 不
Four bytes character:
𠹷
or
𨈇
equivalent of U+20E9D 𠺝
groupés par 3 不𠹷𨈇创
Create a smartsearch module in frontend
Search
For any Chinese character or group of characters, but specially for the 4 bytes
𠹷
and
𨈇
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-08 09:45:27 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
This will make all search case insensitive. Kinda unconvinced that's what we need