[#28577] - [4.0] Alignment of question in batch modal
- Fixed in Code Base
- 5 Apr 2020
- Medium
- Build: 4.0-dev
- Easy Test
- # 28577
- Diff
- chmst:alignment-batch-question
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
In the match modal of categories, the move-or-copy question is a text, followed by a select typr radio.
The text ist not tagged as label, which is an a11y issue
and it gives a alignment issue if the text is short - see PR 28447
Testing Instructions
You need a few categories.
mark them, go to action batch
and move or copy categories.
Watch the alignment of the question and the related radio buttons.
Make sure that copy and move works as before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
J4 Issue
|
||
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
This should not be RTC for the reasons I commented above
| Status | Ready to Commit | ⇒ | Pending |
Removing RTC since the PR has a for="batch-copy-move-id" but an element with id="batch-copy-move-id" doesn't exist.
Maybe it should have been for="batch-copy-move"?
But then still the other aspects of @brianteeman's comment should be checked.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
I have tested this item
Code review: An html element with an id as refered to by the "for" attribute doesn't exist.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
| Labels |
Added:
?
Removed: J4 Issue |
||
| Category | Layout | ⇒ | Layout Front End Plugins |
| Category | Layout Front End Plugins | ⇒ | Layout |
the fieldest and ID are all good now - thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-05 12:35:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 89f707a
Tested successful in combination with #28447
Radio groups are perfectly aligned with the shorter text.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.