NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
4 Apr 2020

We don't actually use vueify - we use webpack to compile - it also causes a bunch of our registered npm audit issues and so this removes it.

Testing Instructions

Try media manager and ensure there are no differences in behaviour from before patch

Also see media manager system tests pass

avatar wilsonge wilsonge - open - 4 Apr 2020
avatar wilsonge wilsonge - change - 4 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2020
Category NPM Change
avatar wilsonge wilsonge - change - 4 Apr 2020
The description was changed
avatar wilsonge wilsonge - edited - 4 Apr 2020
avatar wilsonge wilsonge - change - 4 Apr 2020
Title
Remove vueify - we use webpack in media manager
[4.0] Remove vueify - we use webpack in media manager
avatar wilsonge wilsonge - edited - 4 Apr 2020
avatar richard67
richard67 - comment - 4 Apr 2020

I have tested this item successfully on 01389e0

Have applied the patch with "git apply" on a clean 4.0-dev, did a composer install and npm ci and then installed J4. After that played with the media manager and all was fine. Have also verified that vueify was really not there anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28571.

avatar richard67 richard67 - test_item - 4 Apr 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 4 Apr 2020

I have tested this item successfully on 01389e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28571.

avatar jwaisner jwaisner - test_item - 4 Apr 2020 - Tested successfully
avatar jwaisner jwaisner - change - 4 Apr 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 4 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28571.

avatar richard67 richard67 - change - 4 Apr 2020
Labels Added: ? ? NPM Resource Changed
avatar wilsonge wilsonge - change - 4 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-04 23:01:22
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 4 Apr 2020
avatar wilsonge wilsonge - merge - 4 Apr 2020
avatar wilsonge
wilsonge - comment - 4 Apr 2020

Cheers guys!

Add a Comment

Login with GitHub to post a comment