Feeling Lucky
NPM Resource Changed
?
?
[#28571] - [4.0] Remove vueify - we use webpack in media manager
- Fixed in Code Base
- 4 Apr 2020
- Medium
- Build: 4.0-dev
- # 28571
- Diff
- wilsonge:fix/remove-vueify
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
We don't actually use vueify - we use webpack to compile - it also causes a bunch of our registered npm audit issues and so this removes it.
Testing Instructions
Try media manager and ensure there are no differences in behaviour from before patch
Also see media manager system tests pass
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
| Title |
|
||||||
jwaisner
- comment
- 4 Apr 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28571.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 4 Apr 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28571.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-04 23:01:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
wilsonge
- comment
- 4 Apr 2020
Cheers guys!
I have tested this item✅ successfully on 01389e0
Have applied the patch with "git apply" on a clean 4.0-dev, did a composer install and npm ci and then installed J4. After that played with the media manager and all was fine. Have also verified that vueify was really not there anymore.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28571.