? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Apr 2020

This PR corrects the markup in the xml to match the existing standards. It also removes some classes that are not required and fixes the switcher.

I also changed the name from Joomla Token to API Token as I believe it to be a more accurate description but maybe @nikosdion and @wilsonge disagree. I am not precious about the name

To test make sure you have enabled the user - token plugin and that you check the plugin layout as well as the layout in the user profile

before

image

after

image

before

image

after

image

avatar brianteeman brianteeman - open - 3 Apr 2020
avatar brianteeman brianteeman - change - 3 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2020
Category Administration Language & Strings Front End Plugins
avatar brianteeman brianteeman - change - 3 Apr 2020
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 4 Apr 2020

I'm ok if you wanna put API in the name. I kinda agree with Nic - that API Token on it's own probably isn't the best name - because it is plugin based and there may well be different plugins (especially because I assume there will be a community provided oAuth token provider that will happen for enterprise sites).

avatar brianteeman
brianteeman - comment - 4 Apr 2020

I have updated the PR to be " Joomla API token"

avatar alikon
alikon - comment - 6 Apr 2020

I have tested this item successfully on 2002cb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28561.

avatar alikon alikon - test_item - 6 Apr 2020 - Tested successfully
avatar wilsonge wilsonge - change - 6 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-06 11:14:21
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Apr 2020
avatar wilsonge wilsonge - merge - 6 Apr 2020
avatar wilsonge
wilsonge - comment - 6 Apr 2020

Thanks!

avatar brianteeman
brianteeman - comment - 6 Apr 2020

thanks

Add a Comment

Login with GitHub to post a comment