? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Apr 2020

This PR corrects the markup in the pagination and as a result removes the need for the additional custom css. The onhover highlighting works a bit better but you probably wont notice that. We also get rounded corners as per the rest of the template.

Thanks @C-Lodder and @SharkyKZ for pointing this out

This also fixes the direction of the arrows in RTL langauges

As this changes the scss this pr requires you to run npm i or node build.js --compile-css or to download the prebuilt packages

Testing Instructions

Make sure that you test pagination in the front end and in the admin

Before

before

After

after

Before RTL

image

After RTL

image

avatar brianteeman brianteeman - open - 3 Apr 2020
avatar brianteeman brianteeman - change - 3 Apr 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2020
Category Administration Templates (admin) Layout Front End Templates (site)
avatar brianteeman brianteeman - change - 3 Apr 2020
The description was changed
avatar brianteeman brianteeman - edited - 3 Apr 2020
avatar brianteeman brianteeman - change - 3 Apr 2020
Labels Added: ?
aba8073 4 Apr 2020 avatar brianteeman rtl
avatar brianteeman brianteeman - change - 4 Apr 2020
The description was changed
avatar brianteeman brianteeman - edited - 4 Apr 2020
avatar brianteeman brianteeman - change - 4 Apr 2020
The description was changed
avatar brianteeman brianteeman - edited - 4 Apr 2020
avatar wilsonge wilsonge - change - 4 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-04 11:31:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Apr 2020
avatar wilsonge wilsonge - merge - 4 Apr 2020
avatar brianteeman
brianteeman - comment - 4 Apr 2020

Thanks

avatar wilsonge
wilsonge - comment - 4 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment