Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28533] - [4.0] Version Compare: encoded/decoded

?
avatar chmst
chmst
1 Apr 2020

Steps to reproduce the issue

Take any article, change something in the text and store.
Then go to version, mark 2 versions and call "compare".

Expected result

like in Version 3.9, toggling html / plain text is possible
only changed parts are highlighted,

screen shot 2020-04-01 at 13 51 44

Actual result

no toggling possible,
html code of version1 is compared against encoded version2 is compared against Html encoded content.

screen shot 2020-04-01 at 13 46 31

System information (as much as possible)

Additional comments

avatar chmst chmst - open - 1 Apr 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Apr 2020
avatar C-Lodder
C-Lodder - comment - 1 Apr 2020

Replace this line:

https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/com_contenthistory/js/admin-compare-compare.es6.js#L32

with:

display.insertAdjacentHTML('afterbegin', fragment.textContent);
avatar chmst
chmst - comment - 1 Apr 2020

@C-Lodder thank you! Now the difference is shown with html tags

compare2

But highlighting of the differnce is missing. Sorry, but js is not my field of experience.

avatar C-Lodder
C-Lodder - comment - 1 Apr 2020

PR: #28536

avatar Quy Quy - change - 1 Apr 2020
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-04-01 17:59:08
Closed_By ⇒ Quy
avatar Quy Quy - close - 1 Apr 2020

Add a Comment

Login with GitHub to post a comment