[#28516] - Use plugin name for path lookup
- Fixed in Code Base
- 1 Apr 2020
- Medium
- Build: staging
- # 28516
- Diff
- Digital-Peak:fields/paths
User tests: Successful: Unsuccessful:
Summary of Changes
com_fields does support multiple custom fields in one plugin. Unfortunately the layout path lookup doesn't work as intended. This pr adds an additional lookup for the plugin, which is actually the correct way.
Testing Instructions
- Copy the file /plugins/fields/text/tmpl/text.php to /plugins/fields/text/tmpl/text2.php
- Create a new article custom field of type text 2
- Create an article and set a value for the field text 2
- Open the article on the front
Expected result
The value of text 2 is displayed.
Actual result
An error is thrown:
/plugins/fields/text2/tmpl/default.php: failed to open stream: No such file or directory in /administrator/components/com_fields/libraries/fieldsplugin.php
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
The only reason I see is BC.
But the b/c break would be if plugins were loading their field templates from other plugins right?
This one here is about the lookup itself in the plugin. When the type differs from the name then it would not work anymore if we replace the original lookup.
I have tested this item
I like this solution. The old broken solution can still be deleted by a separate PR if desired.
Thank you @laoneo, with this PR I have learned how I hopefully can solve something a little easier. I've always helped myself with overrides for my own custom field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28516.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28516.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28516.
@HLeithner in J4 we can change that. But I need this fix in J3 as well.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-01 13:50:06 |
| Closed_By | ⇒ | HLeithner |
Thanks
Sure. I can even do it now so we wont forget.
Is there any reason we need to support the old path and not just use the better way if it's currently broken?