? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
29 Mar 2020

Summary of Changes

  • Cleans up the dispatchers to use the CMSApplicationInterface rather than the concrete CMSApplication class (the module dispatcher was incorrectly using it already but after #28506 is merged all will be fine there).
  • Removes duplicated declared properties in ApiDispatcher that were left over from earlier incarnations of the class. Cleaned up a doc block in ApiDispatcher too to correctly reflect why we override the method.

Testing Instructions

Check the Joomla components still load correctly. No changes expected in the interface

Documentation Changes Required

Nothing new - docs will be added when the dispatcher class itself is documented

avatar wilsonge wilsonge - open - 29 Mar 2020
avatar wilsonge wilsonge - change - 29 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2020
Category CLI Libraries
avatar wilsonge wilsonge - change - 29 Mar 2020
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2020
Category CLI Libraries Libraries
avatar wilsonge wilsonge - change - 29 Mar 2020
The description was changed
avatar wilsonge wilsonge - edited - 29 Mar 2020
avatar wilsonge wilsonge - change - 30 Mar 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-30 09:21:45
Closed_By wilsonge
Labels Removed: ?
avatar wilsonge wilsonge - close - 30 Mar 2020
avatar wilsonge wilsonge - merge - 30 Mar 2020

Add a Comment

Login with GitHub to post a comment