[#28496] - [4.0] Pagination corners
- Closed
- 1 Apr 2020
- Very low
- Build: 4.0-dev
- Easy Test
- # 28496
- Diff
- brianteeman:pagination
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
In the admin everything is using rounded corners now. This PR applies the same to the pagination. Easiest page to check on is com_plugins
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
example?
Currently page-link class is applied to li element but it should be applied to the link. See BS documentation https://getbootstrap.com/docs/4.4/components/pagination/.
Once this is corrected, no additional CSS should be needed.
feel free to submit a pr
jwaisner
- | Priority | Medium | ⇒ | Very low |
| Easy | No | ⇒ | Yes |
Moving page-link to the a is not enough
You have to replace it on the li with page-item AND then update the css because that gives a solid black bar
this is so much easier
If the markup matches that of the BS documentation, then no CSS should be updated. The only visual differences between BS and Joomla pagination are the colours, which should simply be done in the variables.scss.
You're welcome to take the code from my backend template which uses the correct classes on each element: https://github.com/C-Lodder/joomla4-backend-template/blob/master/html/layouts/joomla/pagination/link.php
Sick of people saying they have already fixed it in their code and dont contribute it themselves
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-01 15:06:36 |
| Closed_By | ⇒ | brianteeman |
Because I'm sick and tired of fixing bugs introduced on code I've already fixed.
It was broken when the template override for the pagination was removed and the markup wasn't ported over to the core layout properly.
Thanks, but pagination markup should be fixed instead.