? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
28 Mar 2020

Relates to Issue #28474 .

Summary of Changes

This adds a field to allow disabling the tags and version history plugins for specific content types per the original TODO by @nikosdion

Testing Instructions

image

Note the plugin doesn't control the form fields - so the tags form field and content history modals will still render - however they will not ever save tags nor versions (nor will you be able to delete them - everything will effectively become readonly and in stasis)

Right now there is a "known" bug (part of the reason why this is a draft) which is that when you try and unselect all options from the new field you are unable to. I can work on that if people like the concept (see the next section) - however otherwise this is ready to be tested.

Do we need this?

If we do this the logical thing would be to migrate this functionality away from the option we currently have in global config.

Obviously it would be nicer from a UX point if these plugins controlled the tags/versions plugins - but I'm not sure that's a b/c break we want to make at this point in the j4 lifecycle (i.e. looking to do beta before the end of May)

There is obviously the other option to leave this sorta thing for J5 and delete the TODO message in the meantime (probably the better option)

Documentation Changes Required

Obviously will need documentation

avatar wilsonge wilsonge - open - 28 Mar 2020
avatar wilsonge wilsonge - change - 28 Mar 2020
Status New Pending
avatar wilsonge wilsonge - change - 28 Mar 2020
The description was changed
avatar wilsonge wilsonge - edited - 28 Mar 2020
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2020
Category Administration Language & Strings Libraries Front End Plugins
avatar brianteeman
brianteeman - comment - 28 Mar 2020

Is "remove from" the correct term? That suggests it will remove any existing tags/version etc.

If I understand this correctly what this is intended to do is to "disable" the use of tags/versions with a specific component(s)

avatar richard67
richard67 - comment - 29 Mar 2020

I have the same thoughts as @brianteeman has regarding the wording "remove ...".

avatar wilsonge
wilsonge - comment - 29 Mar 2020

Yup remove probably isn't the best word

avatar wilsonge wilsonge - change - 11 Apr 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-04-11 11:58:54
Closed_By wilsonge
Labels Added: ? ? ?
avatar wilsonge wilsonge - close - 11 Apr 2020
avatar richard67
richard67 - comment - 11 Apr 2020

@wilsonge Why closed? Because nobody tested? Or because you are working on a new, different approach?

avatar wilsonge
wilsonge - comment - 11 Apr 2020

No - I have a whole section here about whether we really need this. As we don't have anybody jumping up and down in favour I'm closing and just removing the todo labels - I haven't deleted the branch here - we can always restore if there is time

Add a Comment

Login with GitHub to post a comment