Feeling Lucky
?
[#28477] - Fix typehints in library controllers
- Fixed in Code Base
- 27 Mar 2020
- Medium
- Build: 4.0-dev
- # 28477
- Diff
- wilsonge:controller-typehints
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Now we have void typehints with our PHP 7.2 requirement we can add void typehints into the main library Controllers
Testing Instructions
Code review
Documentation Changes Required
None (these typehints are already in the code and will be documented appropriately)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
ChristineWk
- comment
- 27 Mar 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28477.
1st and 2nd one
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-27 15:31:12 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 27 Mar 2020
Thanks guys!
I have tested this item✅ successfully on 911f227
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28477.