? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
25 Mar 2020

Summary of Changes

Make sure the item ids are integers and use the same variable like in the rest of the code for the menus checkin method

Testing Instructions

  • make sure the com_menus check in still works.

Expected result

the passed ids are now checked to be integer

Actual result

the passed ids where not checked whether they where integers or not.

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 25 Mar 2020
avatar zero-24 zero-24 - change - 25 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2020
Category Administration com_menus
avatar richard67
richard67 - comment - 26 Mar 2020

I have tested this item successfully on 79c190a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28459.

avatar richard67 richard67 - test_item - 26 Mar 2020 - Tested successfully
avatar Quy
Quy - comment - 26 Mar 2020

I have tested this item successfully on 79c190a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28459.

avatar Quy Quy - test_item - 26 Mar 2020 - Tested successfully
avatar Quy Quy - change - 26 Mar 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28459.

avatar zero-24
zero-24 - comment - 26 Mar 2020

Thanks for the tests ?

avatar wilsonge wilsonge - change - 27 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-27 16:09:48
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 27 Mar 2020
avatar wilsonge wilsonge - merge - 27 Mar 2020
avatar wilsonge
wilsonge - comment - 27 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment