? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
25 Mar 2020

Summary of Changes

added the option to filter users by:

  • active
  • state
  • search
  • groupid
  • registration date
  • last visit date

Testing Instructions

call JROOT_URL/api/index.php/v1/users?filter[groupid]=8
call JROOT_URL/api/index.php/v1/users?filter[lastVisitDateStart]=2020-01-29T20:36:01Z
call JROOT_URL/api/index.php/v1/users?filter[search]=myName
call JROOT_URL/api/index.php/v1/users?filter[state]=0
call JROOT_URL/api/index.php/v1/users?filter[active]=1
call JROOT_URL/api/index.php/v1/users?filter[registrationDateStart]=2018-01-29T20:36:01Z
call JROOT_URL/api/index.php/v1/users?filter[registrationDateEnd]=2020-01-29T20:36:01Z
or any combination like :
JROOT_URL/api/index.php/v1/users?filter[groupid]=8&filter[state]=0
etc

Expected values for registrationDateStart , registrationDateEnd and lastVisitDateStart,lastVisitDateEnd are:

2020-03-29T20:36:01Z
2020-03-29T20:36:01+00:00

Expected result

the api response is filtered

Actual result

N/A

Documentation Changes Required

yes

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar alikon alikon - open - 25 Mar 2020
avatar alikon alikon - change - 25 Mar 2020
Status New Pending
avatar alikon alikon - change - 26 Mar 2020
Labels Added: ?
ce92a86 26 Mar 2020 avatar alikon oops
avatar Quy
Quy - comment - 27 Mar 2020

I have tested this item successfully on 893d051


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.

avatar Quy Quy - test_item - 27 Mar 2020 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 9 Apr 2020

I have tested this item ? unsuccessfully on 893d051

{{base_path}}/api/index.php/v1/users?filter[status]=1
{{base_path}}/api/index.php/v1/users?filter[status]=0

return the same list of users

{{base_path}}/api/index.php/v1/users?users?filter[registrationdate]=never

returns a list of users who have the registration date

immagine

Same list of 3 users is given from
{{base_path}}/api/index.php/v1/users?users?filter[lastvisitdate]=never


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.
avatar Razzo1987 Razzo1987 - test_item - 9 Apr 2020 - Tested unsuccessfully
avatar Quy
Quy - comment - 9 Apr 2020

The example is incorrect. [status] should be [state].

avatar Quy
Quy - comment - 9 Apr 2020

See comment in testing instructions:

never (make sense only for lastvisitdate)

avatar alikon alikon - change - 9 Apr 2020
The description was changed
avatar alikon alikon - edited - 9 Apr 2020
avatar alikon
alikon - comment - 9 Apr 2020

thanks @Quy updated the Testing Instructions

avatar Quy
Quy - comment - 9 Apr 2020

JROOT_URL/api/index.php/v1/users?filter[groupid]=system&filter[status]=0

This too please.

avatar alikon alikon - change - 9 Apr 2020
The description was changed
avatar alikon alikon - edited - 9 Apr 2020
avatar alikon alikon - change - 9 Apr 2020
The description was changed
avatar alikon alikon - edited - 9 Apr 2020
avatar Quy
Quy - comment - 9 Apr 2020

filter[groupid]=system

Should be integer.

avatar alikon alikon - change - 9 Apr 2020
The description was changed
avatar alikon alikon - edited - 9 Apr 2020
avatar Razzo1987
Razzo1987 - comment - 9 Apr 2020

I have tested this item successfully on 893d051

re tested. it works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.
avatar Razzo1987 Razzo1987 - test_item - 9 Apr 2020 - Tested successfully
avatar alikon alikon - change - 9 Apr 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 9 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.

avatar alikon alikon - edited - 9 Apr 2020
avatar alikon alikon - change - 11 Apr 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2020
Category Administration com_users
avatar alikon
alikon - comment - 11 Apr 2020

this needs to be retested
cause we have now differnt and better filter for: registrationDate/lastVisitDate

  • registrationDateStart
  • registrationDateEnd
  • lastVisitDateStart
  • lastVisitDateEnd
avatar alikon alikon - change - 11 Apr 2020
The description was changed
avatar alikon alikon - edited - 11 Apr 2020
avatar Quy Quy - change - 12 Apr 2020
The description was changed
avatar Quy Quy - edited - 12 Apr 2020
avatar Quy Quy - change - 12 Apr 2020
Status Ready to Commit Pending
avatar Razzo1987
Razzo1987 - comment - 18 Apr 2020

I have tested this item ? unsuccessfully on c11fd11

Start & End inverted ;)

This example output the users:
{{base_path}}/api/index.php/v1/users?filter[lastVisitDateEnd]=2010-04-18T14:52:20Z&filter[lastVisitDateStart]=2050-04-18T14:52:20Z
If we have Start < End doesn't :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.
avatar Razzo1987 Razzo1987 - test_item - 18 Apr 2020 - Tested unsuccessfully
avatar faustonenci
faustonenci - comment - 18 Apr 2020

I have tested this item ? unsuccessfully on c11fd11

not work

JROOT_URL/api/index.php/v1/users?filter[lastVisitDateStart]=2020-01-29T20:36:01Z

work if
inverted Date with Start

JROOT_URL/api/index.php/v1/users?filter[lastVisitStartDate]=2020-01-29T20:36:01Z

idem for
JROOT_URL/api/index.php/v1/users?filter[registrationDateStart]=2018-01-29T20:36:01Z
JROOT_URL/api/index.php/v1/users?filter[registrationDateEnd]=2020-01-29T20:36:01Z


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.
avatar faustonenci faustonenci - test_item - 18 Apr 2020 - Tested unsuccessfully
df5d791 18 Apr 2020 avatar alikon fix
avatar alikon alikon - change - 18 Apr 2020
Labels Removed: ?
8e1c0e5 18 Apr 2020 avatar alikon fix
avatar alikon
alikon - comment - 18 Apr 2020

we have had a live debug sesion with the help of @Razzo1987
now should be fixed
please retest @Razzo1987

avatar faustonenci
faustonenci - comment - 19 Apr 2020

I have tested this item successfully on 8e1c0e5

good !


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.

avatar faustonenci faustonenci - test_item - 19 Apr 2020 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 19 Apr 2020

I have tested this item successfully on 8e1c0e5

Now Start & End works correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.

avatar Razzo1987 Razzo1987 - test_item - 19 Apr 2020 - Tested successfully
avatar richard67 richard67 - change - 19 Apr 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 19 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.

avatar wilsonge wilsonge - close - 19 Apr 2020
avatar wilsonge wilsonge - merge - 19 Apr 2020
avatar wilsonge wilsonge - change - 19 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-19 15:04:12
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 19 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment