Joomla! Issue Tracker | Joomla! CMS #28451 - [4.0][api][com_users]

? ?

Fixed in Code Base
19 Apr 2020
Medium
Build: 4.0-dev
# 28451
Diff
alikon:patch-112

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

alikon
25 Mar 2020

Summary of Changes

added the option to filter users by:

active
state
search
groupid
registration date
last visit date

Testing Instructions

call JROOT_URL/api/index.php/v1/users?filter[groupid]=8
call JROOT_URL/api/index.php/v1/users?filter[lastVisitDateStart]=2020-01-29T20:36:01Z
call JROOT_URL/api/index.php/v1/users?filter[search]=myName
call JROOT_URL/api/index.php/v1/users?filter[state]=0
call JROOT_URL/api/index.php/v1/users?filter[active]=1
call JROOT_URL/api/index.php/v1/users?filter[registrationDateStart]=2018-01-29T20:36:01Z
call JROOT_URL/api/index.php/v1/users?filter[registrationDateEnd]=2020-01-29T20:36:01Z
or any combination like :
JROOT_URL/api/index.php/v1/users?filter[groupid]=8&filter[state]=0
etc

Expected values for registrationDateStart , registrationDateEnd and lastVisitDateStart,lastVisitDateEnd are:

2020-03-29T20:36:01Z
2020-03-29T20:36:01+00:00

Expected result

the api response is filtered

Actual result

N/A

Documentation Changes Required

yes

Votes

# of Users Experiencing Issue

1/1

Average Importance Score

5.00

c052717 25 Mar 2020

add filter

alikon - open - 25 Mar 2020

alikon - change - 25 Mar 2020

Status

New

⇒

Pending

c387cca 26 Mar 2020

send a 400 response

alikon - change - 26 Mar 2020

Labels

Added: ?

ce92a86 26 Mar 2020

oops

d84347c 26 Mar 2020

use Tobscure excepction

1673916 26 Mar 2020

add code 400

1027002 26 Mar 2020

Update api/components/com_users/src/Controller/UsersController.php

2991d57 26 Mar 2020

Codestyle

836ce92 26 Mar 2020

Fix typo

c007b1a 26 Mar 2020

Use invalid field parameter

902bde9 27 Mar 2020

Update api/components/com_users/src/Controller/UsersController.php

893d051 27 Mar 2020

since 4

Quy - comment - 27 Mar 2020

I have tested this item ✅ successfully on 893d051

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

Quy - test_item - 27 Mar 2020 - Tested successfully

Razzo1987 - comment - 9 Apr 2020

I have tested this item ? unsuccessfully on 893d051

{{base_path}}/api/index.php/v1/users?filter[status]=1
{{base_path}}/api/index.php/v1/users?filter[status]=0

return the same list of users

{{base_path}}/api/index.php/v1/users?users?filter[registrationdate]=never

returns a list of users who have the registration date

Same list of 3 users is given from
{{base_path}}/api/index.php/v1/users?users?filter[lastvisitdate]=never

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

Razzo1987 - test_item - 9 Apr 2020 - Tested unsuccessfully

Quy - comment - 9 Apr 2020

The example is incorrect. [status] should be [state].

Quy - comment - 9 Apr 2020

See comment in testing instructions:

never (make sense only for lastvisitdate)

alikon - change - 9 Apr 2020

The description was changed

alikon - edited - 9 Apr 2020

alikon - comment - 9 Apr 2020

thanks @Quy updated the Testing Instructions

Quy - comment - 9 Apr 2020

JROOT_URL/api/index.php/v1/users?filter[groupid]=system&filter[status]=0

This too please.

alikon - change - 9 Apr 2020

The description was changed

alikon - edited - 9 Apr 2020

alikon - change - 9 Apr 2020

The description was changed

alikon - edited - 9 Apr 2020

Quy - comment - 9 Apr 2020

filter[groupid]=system

Should be integer.

alikon - change - 9 Apr 2020

The description was changed

alikon - edited - 9 Apr 2020

Razzo1987 - comment - 9 Apr 2020

I have tested this item ✅ successfully on 893d051

re tested. it works!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

Razzo1987 - test_item - 9 Apr 2020 - Tested successfully

alikon - change - 9 Apr 2020

Status

Pending

⇒

Ready to Commit

alikon - comment - 9 Apr 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

alikon - edited - 9 Apr 2020

720e5a8 11 Apr 2020

Refactor to use full date searches

c11fd11 11 Apr 2020

Merge pull request #67 from wilsonge/imp/users_date

alikon - change - 11 Apr 2020

Labels

Added: ?

joomla-cms-bot - change - 11 Apr 2020

Category

⇒

Administration com_users

alikon - comment - 11 Apr 2020

this needs to be retested
cause we have now differnt and better filter for: registrationDate/lastVisitDate

registrationDateStart
registrationDateEnd
lastVisitDateStart
lastVisitDateEnd

alikon - change - 11 Apr 2020

The description was changed

alikon - edited - 11 Apr 2020

Quy - change - 12 Apr 2020

The description was changed

Quy - edited - 12 Apr 2020

Quy - change - 12 Apr 2020

Status

Ready to Commit

⇒

Pending

Razzo1987 - comment - 18 Apr 2020

I have tested this item ? unsuccessfully on c11fd11

Start & End inverted ;)

This example output the users:
{{base_path}}/api/index.php/v1/users?filter[lastVisitDateEnd]=2010-04-18T14:52:20Z&filter[lastVisitDateStart]=2050-04-18T14:52:20Z
If we have Start < End doesn't :(

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

Razzo1987 - test_item - 18 Apr 2020 - Tested unsuccessfully

faustonenci - comment - 18 Apr 2020

I have tested this item ? unsuccessfully on c11fd11

not work

JROOT_URL/api/index.php/v1/users?filter[lastVisitDateStart]=2020-01-29T20:36:01Z

work if
inverted Date with Start

JROOT_URL/api/index.php/v1/users?filter[lastVisitStartDate]=2020-01-29T20:36:01Z

idem for
JROOT_URL/api/index.php/v1/users?filter[registrationDateStart]=2018-01-29T20:36:01Z
JROOT_URL/api/index.php/v1/users?filter[registrationDateEnd]=2020-01-29T20:36:01Z

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

faustonenci - test_item - 18 Apr 2020 - Tested unsuccessfully

df5d791 18 Apr 2020

fix

alikon - change - 18 Apr 2020

Labels

Removed: ?

8e1c0e5 18 Apr 2020

fix

alikon - comment - 18 Apr 2020

we have had a live debug sesion with the help of @Razzo1987
now should be fixed
please retest @Razzo1987

faustonenci - comment - 19 Apr 2020

I have tested this item ✅ successfully on 8e1c0e5

good !

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

faustonenci - test_item - 19 Apr 2020 - Tested successfully

Razzo1987 - comment - 19 Apr 2020

I have tested this item ✅ successfully on 8e1c0e5

Now Start & End works correctly.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

Razzo1987 - test_item - 19 Apr 2020 - Tested successfully

richard67 - change - 19 Apr 2020

Status

Pending

⇒

Ready to Commit

richard67 - comment - 19 Apr 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28451.}

wilsonge - close - 19 Apr 2020

wilsonge - merge - 19 Apr 2020

wilsonge - change - 19 Apr 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-04-19 15:04:12
Closed_By		⇒	wilsonge
Labels	Added: ?

wilsonge - comment - 19 Apr 2020

Thanks!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#28451] - [4.0][api][com_users] - Add filter options

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Votes

Add a Comment