[#28447] - [4.0] Improve text in batch modal
- Fixed in Code Base
- 25 Sep 2020
- Medium
- Build: 4.0-dev
- # 28447
- Diff
- Quy:24817-batch
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Alternate to #24817.
Summary of Changes
Make Copy/Move label consistent with other labels.
Testing Instructions
Content > Articles > select some articles > click on Batch
Select a category so that the Copy / Move question is shown.
The radio buttons will be fixed if this is approved.
Expected result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Do we need this question? I think Copy / Move is self explaining and dos not need an extra label.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
I have tested this item
Tested the text change successfully.
It shows a different problem....
Now the text is shorter the flex layout puts logically the radio buttons at the end of the text.
Without this change we would probably also have this issue in certain languages.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
I have tested this item
Tested the text change successfully.
It shows a different problem....
Now the text is shorter the flex layout puts logically the radio buttons at the end of the text.
Without this change we would probably also have this issue in certain languages.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
for me we don't need this, but if we need this for newbies then it should be aligned properly
I don't think it matters that we need this specific text in English.
Shortening the text shows an alignment issue, which can easily become an issue report when certain language shows a short text.
So, the aligning needs to be done first, no matter of the text.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
I have tested this item
This works as intended
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
Please see PR #28577
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
I have tested this item
Tested successful in combination with ##28577
The text is correctly updated and the radio group is perfectly aligned.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
I do not agree with this change to JLIB_HTML_BATCH_MOVE_QUESTION
Changing the length of the text in english for layout purposes is wrong as we have no way of knowing how long or short the text will be in other languages.
I do agree with changing the order of the words in the text to match the order of the radio.
How about changing JLIB_HTML_BATCH_MOVE_QUESTION to Action or assign it sr-only so it does not display?
I have tested this item
good
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447.
RTC?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-25 08:12:45 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
Thanks
it isn't the word "Action to perform" a little bit misplace/misaligned to the rest of the modal ?