? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 Mar 2020

Pull Request for Issue #24587 .

Summary of Changes

Breaks up tags code from the interface and adds a corresponding trait.

Note as it shares methods with the CategoryServiceTrait we have to choose to prioritize one of the methods (as they are identical I've arbitrarily chosen CategoryServiceTrait but there's no deeper reasoning for that decison)

Testing Instructions

Check the count of items associated with a tag continues to work in the tags component when you filter by a tag type (e.g. article)

Documentation Changes Required

Yup. New tag interface needs to be documented

avatar wilsonge wilsonge - open - 23 Mar 2020
avatar wilsonge wilsonge - change - 23 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2020
Category Administration com_banners com_contact com_content com_newsfeeds com_tags Libraries
avatar wilsonge wilsonge - change - 23 Mar 2020
Title
Break up tags code from category interface
[4.0] Break up tags code from category interface
avatar wilsonge wilsonge - edited - 23 Mar 2020
avatar wilsonge wilsonge - change - 23 Mar 2020
The description was changed
avatar wilsonge wilsonge - edited - 23 Mar 2020
avatar alikon
alikon - comment - 26 Mar 2020

played with tags and article and article category...... lgtm

avatar alikon
alikon - comment - 26 Mar 2020

I have tested this item successfully on af0ec82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439.

avatar alikon alikon - test_item - 26 Mar 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 26 Mar 2020

I have tested this item successfully on af0ec82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439.

avatar jwaisner jwaisner - test_item - 26 Mar 2020 - Tested successfully
avatar jwaisner jwaisner - change - 26 Mar 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 26 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439.

avatar wilsonge wilsonge - close - 26 Mar 2020
avatar wilsonge wilsonge - merge - 26 Mar 2020
avatar wilsonge wilsonge - change - 26 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-26 23:19:16
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 26 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment