? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
22 Mar 2020

Pull Request for Issue #28414

Summary of Changes

As title says

Testing Instructions

Create an article blog menu item.
Patch.
Log as a user with create permission for that category in frontend

After patch

Screen Shot 2020-03-21 at 09 43 37

avatar infograf768 infograf768 - open - 22 Mar 2020
avatar infograf768 infograf768 - change - 22 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2020
Category Front End com_content
avatar alikon
alikon - comment - 22 Mar 2020

i don't know why js drone AT complains but looking at the current status of all that infrastructure .....
who cares..... surely i don't

avatar alikon
alikon - comment - 22 Mar 2020

I have tested this item successfully on 4ee2d3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28429.

avatar alikon alikon - test_item - 22 Mar 2020 - Tested successfully
avatar alikon
alikon - comment - 22 Mar 2020

please @drjjw test this

avatar infograf768
infograf768 - comment - 22 Mar 2020

Re-started drone...

avatar alikon
alikon - comment - 22 Mar 2020

we cannot stay with this current AT status,
i'm complaining as my usual, but please prove me that i'm wrong

avatar infograf768
infograf768 - comment - 22 Mar 2020

drone ok now

avatar jwaisner
jwaisner - comment - 22 Mar 2020

I have tested this item successfully on 4ee2d3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28429.

avatar jwaisner jwaisner - test_item - 22 Mar 2020 - Tested successfully
avatar jwaisner jwaisner - change - 22 Mar 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 22 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28429.
avatar HLeithner HLeithner - change - 23 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-23 20:29:45
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 23 Mar 2020
avatar HLeithner HLeithner - merge - 23 Mar 2020
avatar HLeithner
HLeithner - comment - 23 Mar 2020

Thanks

avatar Milglius
Milglius - comment - 30 Mar 2020

Why adding new features bugs or intended behavior in joomla 3 is strange and this PR will create a lot of confusion for joomla users at least make this as an option

Not Removing New article button in category list layout but Adding New article button in category blog layout will create a lot of disapintment in joomla

See the joomla problems here #28513 #28509

avatar Milglius
Milglius - comment - 30 Mar 2020

This PR should be release blocker , should be reopen its not ready this solved issue #28414 created issue #28514 issue should be reopen or will create a lot of disapintment in joomla

this is BC issue couse this will break a lot of existing lyouts

avatar Bakual
Bakual - comment - 30 Mar 2020

@Milglius Please stop it. This PR can't be a release blocker since it is merged and there is no issue to solve.

avatar Milglius
Milglius - comment - 30 Mar 2020

will be very unpleasant surprise for joomla 3.9.17 users!

Bakual At least make this 2 issues as an option? Couse This will break lyout of many joomla sites if these are not optional So this issue is BC issue.

#28514 this New article button in the botom should be removed in joomla 3.9.17 couse this button creates confusion and breaks joomla sites layout.

avatar HLeithner
HLeithner - comment - 30 Mar 2020

Lock down see #28514 (comment)

Add a Comment

Login with GitHub to post a comment