? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
21 Mar 2020

A \ before the beginning of a function represents the Global Namespace in PHP. Putting it there will ensure that the function called is from the global namespace, even if there is a function by the same name in the current namespace.

Summary of Changes

I added a backslash in front of defined('_JEXEC') or die; for the namespaced files if it was not already there.
Up to know I covert the folders administrator, components, modules, plugins, layout and template.

Testing Instructions

Code review.

avatar astridx astridx - open - 21 Mar 2020
avatar astridx astridx - change - 21 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2020
Category Administration com_admin
avatar astridx astridx - change - 21 Mar 2020
Title
[4.0] Change 2defined('_JEXEC') or die;" to "\defined('_JEXEC') or die;"
[4.0] Change "defined('_JEXEC') or die;" to "\defined('_JEXEC') or die;"
avatar astridx astridx - edited - 21 Mar 2020
avatar astridx astridx - change - 24 Mar 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2020
Category Administration com_admin Administration com_admin com_associations
avatar astridx astridx - change - 24 Mar 2020
The description was changed
avatar astridx astridx - edited - 24 Mar 2020
avatar zero-24
zero-24 - comment - 24 Mar 2020

merging on review thanks @astridx

avatar zero-24 zero-24 - change - 24 Mar 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-24 22:22:03
Closed_By zero-24
avatar zero-24 zero-24 - close - 24 Mar 2020
avatar zero-24 zero-24 - merge - 24 Mar 2020

Add a Comment

Login with GitHub to post a comment