? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
21 Mar 2020

Summary of Changes

Because I think it is a bug i changed
defined('JPATH_BASE') or die;
into
defined('_JEXEC') or die;

Testing Instructions

Code review.

See #28416 for layout folder

avatar astridx astridx - open - 21 Mar 2020
avatar astridx astridx - change - 21 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2020
Category Administration com_associations com_banners com_categories com_config com_contact com_content com_languages com_menus com_messages com_modules
avatar astridx astridx - change - 21 Mar 2020
Title
Change `defined('JPATH_BASE') or die;` into `defined('_JEXEC') or die;` for all folders all with the exception of layout folder
Change `defined('JPATH_BASE') or die;` into `defined('_JEXEC') or die;` for all folders with the exception of layout folder
avatar astridx astridx - edited - 21 Mar 2020
avatar chmst
chmst - comment - 24 Mar 2020

I have tested this item successfully on 1b38b8d

very nice to have it everywhere the same


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28417.

avatar chmst chmst - test_item - 24 Mar 2020 - Tested successfully
avatar Quy
Quy - comment - 24 Mar 2020

I have tested this item successfully on 1b38b8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28417.

avatar Quy Quy - test_item - 24 Mar 2020 - Tested successfully
avatar Quy Quy - change - 24 Mar 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28417.

avatar zero-24 zero-24 - change - 24 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-24 22:29:04
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 24 Mar 2020
avatar zero-24 zero-24 - merge - 24 Mar 2020
avatar zero-24
zero-24 - comment - 24 Mar 2020

merging thanks @astridx

Add a Comment

Login with GitHub to post a comment