? Pending
Pull Request for # 28408

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 Mar 2020

Fixes #28408.

Summary of Changes

Use multibyte safe strtolower() in some components.

Testing Instructions

Create a module containing multibyte characters, e.g. Ačiū.
In module search field enter Ačiū and submit.

Expected result

Module found.

Actual result

Module not found.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 Mar 2020
avatar SharkyKZ SharkyKZ - change - 20 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2020
Category Administration com_banners com_modules com_templates
avatar SharkyKZ SharkyKZ - change - 20 Mar 2020
Rel_Number 28408
Relation Type Pull Request for
Labels Added: ?
avatar infograf768
infograf768 - comment - 20 Mar 2020

looks ok on review

avatar astridx
astridx - comment - 20 Mar 2020

I just tested that. I'm not sure I understood you correctly. In my test, the string Ačiū is found without a patch.
Modules  Site    test   Administration

avatar infograf768
infograf768 - comment - 20 Mar 2020

I suggest to test with non-latin title. Greek letters for example.

avatar infograf768
infograf768 - comment - 21 Mar 2020

Hmm
tested with Επισκόπηση and it indeed works without patch.
In any case, the PR makes sense.

avatar infograf768
infograf768 - comment - 21 Mar 2020

I have tested this item successfully on 1619400


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28410.

avatar infograf768 infograf768 - test_item - 21 Mar 2020 - Tested successfully
avatar astridx
astridx - comment - 21 Mar 2020

I have tested this item successfully on 1619400

For me it worked with and without the patch for
Ačiū
and for
? Smiling Face.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28410.

avatar astridx
astridx - comment - 21 Mar 2020

I have tested this item successfully on 1619400

For me it worked with and without the patch for
Ačiū
and for
? Smiling Face.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28410.

avatar astridx astridx - test_item - 21 Mar 2020 - Tested successfully
avatar astridx astridx - test_item - 21 Mar 2020 - Tested successfully
avatar infograf768 infograf768 - change - 21 Mar 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-21 09:23:00
Closed_By infograf768
avatar infograf768 infograf768 - close - 21 Mar 2020
avatar infograf768 infograf768 - merge - 21 Mar 2020
avatar infograf768
infograf768 - comment - 21 Mar 2020

tks

Add a Comment

Login with GitHub to post a comment