[#2841] - Frontend ContactModelContact displays stack trace when contact not found
- Closed
- 1 Jan 2015
- Medium
- Build: master
- # 2841
In my implementation, contacts get shuffled around to different categories and they're published and unpublished as well as their access levels changing frequently.
While testing some of my functionality - I ran across a full stack trace in the system message after I changed the access level of a contact.
Line 286 throws Exception, which gives stack trace in the front-end system message.
The error should throw a JException which would give a pretty error message instead of an ugly stack trace.
On top of that, the status code set in the exception isn't carried over to the resulting page - line 301 sets the error, line 302 should set the status code:
JResponse::setHeader('status',$e->getCode());
vdespa
- | Category | ⇒ | ACL Components Front End |
Can you provide steps to replicate this on a clean install?
Also, please note that the line numbers change between versions, so it's best to link to a specific file version (with line number) on github if possible.
Thanks!
@stutteringpoet please provide the information requested by @nicksavov or this will have to be closed n a few weeks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2841.
| Status | New | ⇒ | Information Required |
After no update this is being closed. If you feel it is still an issue please provide more information and it can always be reopened
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2841.
zero-24
- | Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-01 16:52:39 |
| Closed_By | ⇒ | brianteeman |
| Labels |
Added:
?
|
||
While looking at it, I wonder why the model doesn't send an appropriate status for the item instead of always a 404.
Omit line 277: $query->where('a.access IN ('.$groups.')');
and we can run an additional test in the try/catch block to determine if the contact is not found (404 not found) or doesn't have an appropriate access level (401 not authorized)