[#28396] - [4.0] Override-Manager fix
- Fixed in Code Base
- 20 Mar 2020
- Medium
- Build: 4.0-dev
- # 28396
- Diff
- astridx:overridemanager
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
At the moment you can not see in the template manager what function the Switches have. It looks like this to me.
I have also corrected the alignment. For ltr it was only needed to remove a margin. The alignment is OK. For rtl I added the correct alignment.
The label is not inserted. We would have to use
echo $this→form→renderField('show_core');
for this.
I tried to display the label. However, it is difficult to position the switcher with label correctly at this point. Therefore I think it is good to only display the input and to adapt the description text.
Testing Instructions
-
Create an override in the Template Manager and open it for editing. You see two switches. You don't know what these switches do.
-
Apply this patch
-
Switch back to the template manager and see that the description text of the switches now shows the current status. You now know what switch is responsible for.
Expected result
You can see the function that a switch performs based on the label or description.
Actual result
You see switches but you do not know what the switch hide or show.
Additional information
Because of
we need the change in the CSS-file.This is a redo of parts of this PR: #26359
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings Repository NPM Change |
| Title |
|
||||||
I have tested this item
I have successfully tested this patch ;) Thank you!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.
I have tested this patch successfully. Thank you!!!
screen shot 2020-03-19 at 16 42 00
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.
I have tested this item
Tested successfully, thank you!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.
Can the wording « diff » be modified to « differences » ?
Yes, but I like the shorter form. What do others say?
I think it might look better "differences"
| Labels |
Added:
?
|
||
OK, done.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-20 11:33:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
Thanks!
I have tested this item✅ successfully on 7619bb8
I have successfully tested this patch ;) Thank you!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.