Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28388] - [4.0] correct date for .sql update file

? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
18 Mar 2020

Pull Request for Issue #28387 .

Summary of Changes

rename update sql files from 4.0.0-2020-09-03.sql to 4.0.0-2020-03-10.sql

Testing Instructions

review

avatar alikon alikon - open - 18 Mar 2020
avatar alikon alikon - change - 18 Mar 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2020
Category ⇒ SQL Administration com_admin Postgresql
avatar ReLater
ReLater - comment - 18 Mar 2020

But there exists already another and different file "4.0.0-2020-03-09.sql".
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/sql/updates/mysql/4.0.0-2019-03-09.sql

Combine them?

1fc50fc 18 Mar 2020 avatar alikon grr
avatar alikon alikon - change - 18 Mar 2020
Labels Added: ?
2113618 18 Mar 2020 avatar alikon grr
avatar richard67
richard67 - comment - 18 Mar 2020

@ReLater The one you've linked above is same day and month but for 2019, here we deal with 2020 ;-)

avatar richard67
richard67 - comment - 18 Mar 2020

@alikon Last change was not really necessary because @ReLater mixed up 2019 and 2020. But it also doesn't do any harm so you can leave it as it is now.

Update: But if you leave it as it is now, you have to change the file name in your PR description.

avatar alikon
alikon - comment - 18 Mar 2020

grr ,
Screenshot from 2020-03-18 13-54-28
cannot find that on local repo anyway changed

avatar richard67
richard67 - comment - 18 Mar 2020

@alikon If you leave it as it is now, you have to change the file name in your PR description.

avatar ReLater
ReLater - comment - 18 Mar 2020

Oh, sorry, sorry for confusion!!
There is a conflicting file 4.0.0-2020-03-09.sql in my installation.
It comes from pr for plg_system_donttranslate that I applied wit Joomla Patch Tester. #28261

avatar richard67 richard67 - change - 18 Mar 2020
The description was changed
avatar richard67 richard67 - edited - 18 Mar 2020
avatar richard67
richard67 - comment - 18 Mar 2020

I have tested this item ✅ successfully on 2113618

Tested by review. I've changed the new file name in the description so it matches the last changes.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28388.

avatar richard67 richard67 - test_item - 18 Mar 2020 - Tested successfully
avatar wilsonge wilsonge - change - 18 Mar 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-03-18 13:46:54
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 18 Mar 2020
avatar wilsonge wilsonge - merge - 18 Mar 2020
avatar wilsonge
wilsonge - comment - 18 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment