Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28372] - [4.0] Remove adminlist.css

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
16 Mar 2020

Pull Request for Issue # .

Summary of Changes

This PR removes an old CSS file. As far as I can tell, it's not used or needed.

Testing Instructions

  1. Login to the frontend of your Joomla site.
  2. Go to /index.php/submit-article
  3. In the TinyMCE editor toolbar, expand the CMS Content dropdown item and click Menu

This will display a modal.

Ensure the styling of the content

avatar C-Lodder C-Lodder - open - 16 Mar 2020
avatar C-Lodder C-Lodder - change - 16 Mar 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2020
Category ⇒ Repository NPM Change
avatar C-Lodder C-Lodder - change - 16 Mar 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2020
Category Repository NPM Change ⇒ Administration com_menus Repository NPM Change
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2020
Category Repository NPM Change Administration com_menus ⇒ Administration com_menus Repository NPM Change Front End com_contact com_content com_modules
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2020
Category Repository NPM Change Administration com_menus Front End com_contact com_content com_modules ⇒ Administration com_admin com_menus Repository NPM Change Front End com_contact com_content com_modules
avatar Quy
Quy - comment - 16 Mar 2020

Remove use Joomla\CMS\HTML\HTMLHelper; in DisplayController.php files.

avatar C-Lodder
C-Lodder - comment - 16 Mar 2020

Thanks @Quy, done

avatar C-Lodder C-Lodder - change - 16 Mar 2020
The description was changed
avatar C-Lodder C-Lodder - edited - 16 Mar 2020
avatar infograf768
infograf768 - comment - 16 Mar 2020

Not on desktop right now, but If I remember well, there was a class loaded in an xtd modal

avatar jwaisner jwaisner - change - 16 Mar 2020
Priority Medium ⇒ Low
avatar chmst
chmst - comment - 16 Mar 2020

I have tested this item ✅ successfully on d26f4c3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28372.

avatar chmst chmst - test_item - 16 Mar 2020 - Tested successfully
avatar ciar4n
ciar4n - comment - 16 Mar 2020

I have tested this item ✅ successfully on d26f4c3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28372.

avatar ciar4n ciar4n - test_item - 16 Mar 2020 - Tested successfully
avatar Quy Quy - change - 16 Mar 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 16 Mar 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28372.

avatar wilsonge
wilsonge - comment - 16 Mar 2020

@infograf768 can you please get back tomorrow morning on your checks

avatar C-Lodder
C-Lodder - comment - 17 Mar 2020

I have checked the entire repo (PHP) code for references to adminlist after these changes. It's only used in PHP classes

avatar infograf768
infograf768 - comment - 17 Mar 2020

@C-Lodder @wilsonge

Here is an animated gif of the articles XTD used when editing an article in frontend.

adminlist

Screen Shot 2020-03-17 at 08 44 47

Remark the change in family font.

I am not saying we should keep adminlist because of that. It looks like it is indeed a useless override.

avatar brianteeman
brianteeman - comment - 17 Mar 2020

Good memory @infograf768

I agree with your conclusion that this change in font is not needed or even desired and this css can be removed

avatar wilsonge wilsonge - change - 17 Mar 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-03-17 08:38:01
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Mar 2020
avatar wilsonge wilsonge - merge - 17 Mar 2020
avatar wilsonge
wilsonge - comment - 17 Mar 2020

Thanks!

avatar wilsonge
wilsonge - comment - 17 Mar 2020

Nice memory indeed JM!

Add a Comment

Login with GitHub to post a comment