? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
16 Mar 2020

Followup to #27992.

Summary of Changes

Updates remaining #__content_types entries with fully qualified class names.

Note, this also changes article table from Joomla\CMS\Table\Content to Joomla\Component\Content\Administrator\Table\ArticleTable. I'm actually not sure if this is needed or not, or why this class was added to 4.0 in the first place. Need feedback on this.

Testing Instructions

This will need to be tested both for new installations and for upgrades from 3.10. Not sure how to test upgrades - the code doesn't seem to be executed when updating from 3.10-dev?

Create and edit some categories for different content types.
Create and edit some articles.
In edit form click Versions button. Check that current item version is marked with a star.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 16 Mar 2020
avatar SharkyKZ SharkyKZ - change - 16 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2020
Category Administration com_admin SQL Installation Postgresql
avatar wilsonge
wilsonge - comment - 7 Apr 2020

Note, this also changes article table from Joomla\CMS\Table\Content to Joomla\Component\Content\Administrator\Table\ArticleTable. I'm actually not sure if this is needed or not, or why this class was added to 4.0 in the first place. Need feedback on this.

Aim is to move component specific classes out of the common library tables. They were originally there because getting them out of components wasn't easy/obvious. Now that we the MVCFactories within components - this is much easier than previously and it makes more sense to use them rather than have them in central libraries structure.

avatar wilsonge
wilsonge - comment - 7 Apr 2020

If you can fix conflicts here will try and get this merged

avatar SharkyKZ SharkyKZ - change - 7 Apr 2020
Labels Added: Conflicting Files ?
avatar SharkyKZ
SharkyKZ - comment - 7 Apr 2020

Conflicts solved.

avatar wilsonge wilsonge - change - 7 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-07 21:50:48
Closed_By wilsonge
Labels Removed: Conflicting Files
avatar wilsonge wilsonge - close - 7 Apr 2020
avatar wilsonge wilsonge - merge - 7 Apr 2020
avatar wilsonge
wilsonge - comment - 7 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment