? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Mar 2020

removes the useless reference to descriptions and the associated strings

testing

create a custom admin menu
creats an admin menu of type articles list

before

image

after

image

avatar brianteeman brianteeman - open - 16 Mar 2020
avatar brianteeman brianteeman - change - 16 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2020
Category Administration com_content Language & Strings
avatar wilsonge
wilsonge - comment - 16 Mar 2020

I think access needs to change as the label if we do this to viewing access level. Because otherwise without the description it implies a access group rather than a View Access

avatar infograf768
infograf768 - comment - 16 Mar 2020

Or just leave the description for that one. Easier.

avatar brianteeman
brianteeman - comment - 16 Mar 2020

On my phone so can't check but what do other admin menu do?

avatar brianteeman
brianteeman - comment - 16 Mar 2020

On my phone so can't check but what do other admin menu do?

avatar jwaisner jwaisner - change - 16 Mar 2020
Priority Medium Low
avatar brianteeman
brianteeman - comment - 24 Mar 2020

I think access needs to change as the label if we do this to viewing access level. Because otherwise without the description it implies a access group rather than a View Access

The problem is that the column it is referring to is called Access.
Managing the items displayed here is done in the menu item "Access"

So if you want to change the name from access then it should be done everywhere.

This PR is correct for the current interface of joomla

avatar infograf768
infograf768 - comment - 24 Mar 2020

Let's leave the description. Why systematically and blindly take off descriptions under the pretext of a "current interface" ?
In some cases, the description is just redundant, but here it IS useful...

avatar brianteeman
brianteeman - comment - 24 Mar 2020

lets stay in the dark age as well

avatar infograf768
infograf768 - comment - 24 Mar 2020

Referencing to the "Dark ages" is just a kind of Godwin's law for some people who have no more argument to oppose to simple common sense statements.

avatar brianteeman
brianteeman - comment - 24 Mar 2020

Look at the options you get when you use this. It is absolutely clear that this is viewing levels. Just as it is absolutely clear that the access filter for articles is for viewing levels.

image

image

avatar Quy
Quy - comment - 27 Mar 2020

I have tested this item successfully on 4593cff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28362.

avatar Quy Quy - test_item - 27 Mar 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 7 Apr 2020

I have tested this item successfully on 4593cff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28362.

avatar jwaisner jwaisner - test_item - 7 Apr 2020 - Tested successfully
avatar jwaisner jwaisner - change - 7 Apr 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 7 Apr 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28362.

avatar wilsonge wilsonge - change - 8 Apr 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-08 21:30:35
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 8 Apr 2020
avatar wilsonge wilsonge - merge - 8 Apr 2020

Add a Comment

Login with GitHub to post a comment