Feeling Lucky
?
[#28352] - [4.0] Cleanup formvalidation uses
- Fixed in Code Base
- 16 Mar 2020
- Medium
- Build: 4.0-dev
- # 28352
- Diff
- wilsonge:fix/javascript-validation-cleanup
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #25490 .
Summary of Changes
- Adds the class
form-validateto various forms so that they are correctly used by the validator. - Adds the formvalidator javascript to the installer where we had the classes but not the JS
- Removes the
data-cancel-taskattribute from com_config where we now no longer use core mvc and it follows the "normal" task pattern
Basically every form using the formvalidator behaviour is now associated with a form containing the form-validate class. (The password field additionally includes the behaviour without the class but that is outside the scope of the PR as the JS has a hard dependency)
Testing Instructions
Ensure form validation in forms continues to work especially in the forms affected in this PR
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_config com_media com_messages Front End Installation |
jwaisner
- comment
- 16 Mar 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 16 Mar 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-16 14:13:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 16 Mar 2020
Cheers guys
I have tested this item✅ successfully on 9d3b8f5
All forms work as before, so it is successful test.
Validation itself does not work for numbers but this is not in scope of this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352.