User tests: Successful: Unsuccessful:
Pull Request for Issue #27924 .
This PR adds handling of exceptions which are thrown by the installation's database model in routine createDatabase but never were caught and handled so that e.g. the bad connfiguration file after a bad attemt to create the database was not deleted.
Step 1: Start a new installation of a current 4.0-dev without the patch of this PR applied.
Step 2: When coming to the database information, enter a valid server and a valid user name and password for a user who doesn't have the privilege to create databases. Enter a database name for which no database exists. When having filled out all fields, use the "Install Joomla >" button to start the installation.
Result: Depending on the particular database driver you see a more or less meaningful error message.
Step 3: Correct the database name so it fits to an existing database for which the previously entered user has all privileges required for a Joomla installation, or alternatively change user to one who has the privilege to create a new database. Then use the "Install Joomla >" button again.
Result: For MySQLi and MySQL (PDO): See section "Actual result" below. For PostgreSQL (PDO). it might be like described in section "Expected result".
Step 4: Repeat steps 1 to 3 but this time with the patch of thos PR applied.
Result: See section "Expected result" below.
When entering a not existing database as database name in the installation form and a user who doesn't have the permission to create a database, you can correct database or user information after the error message and then continue with the installation by using again the "Install Joomla >" button.
When entering a not existing database as database name in the installation form and a user who doesn't have the permission to create a database, and then after the error message correct database or user information and start the installation again, it stops with an unspecified database error, at least when using MySQLi or MySQL (PDO). For PostgreSQL the error could not be reproduced before..
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Installation |
Labels |
Added:
?
?
|
I have tested this item
Tested successful with MySQLi
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-17 16:15:45 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Thanks, too.
Added release blocker label as inherited from issue #27924 .