[#2832] - Cache loading router to prevent extra filesystem calls
- Closed
- 27 Jul 2014
- Medium
- Build: staging
- # 2832
- Diff
- pasamio:router_fileexists
- Foreign ID 33186
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This change shifts the code to import the component specific router in a single function instead of inlining it with the rest of the SEF route generation code. This should also make this segment of code easier to unit test later.
The main reason for the change is to prevent redundant file_exists checks for the router when the router has already been loaded. This is problematic on slow disks and in situations where JFile::read is used (JFile::read triggers clearstatcache which wipes out PHP's cache; this is irrelevant to Joomla as the file would have already been loaded anyway).
This can help improve performance particularly on network shared Joomla instances (e.g. NFS filer).
JoomlaCode issue: https://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33186&start=0
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-27 14:38:39 |
Thanks for contributing this but it appears to have been fixed elsewhere in the meantime