? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 Mar 2020

Summary of Changes

fix notice in httpheaders plugin cc @wilsonge should be obvious on code review.

avatar zero-24 zero-24 - open - 11 Mar 2020
avatar zero-24 zero-24 - change - 11 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2020
Category Front End Plugins
avatar Quy
Quy - comment - 11 Mar 2020

I get the following in the back end:

Warning: hash() expects parameter 2 to be string, array given in \plugins\system\httpheaders\httpheaders.php on line 165

avatar zero-24
zero-24 - comment - 11 Mar 2020

hmm it seams something different is happening here:

https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/httpheaders/httpheaders.php#L154-L178

That results into $scriptContent or $styleContent to be an array but i would like to keep that of for now. Can you please create an issue for that?

An fix could be to check that $scriptContent is an array and than do a loop over them to generate the hashes.

avatar Quy
Quy - comment - 11 Mar 2020

I have tested this item successfully on 7ea1950


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28318.

avatar Quy Quy - test_item - 11 Mar 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 11 Mar 2020

I have tested this item successfully on 7ea1950


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28318.

avatar ChristineWk ChristineWk - test_item - 11 Mar 2020 - Tested successfully
avatar Quy Quy - change - 11 Mar 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28318.

avatar wilsonge wilsonge - change - 11 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-11 22:56:50
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 11 Mar 2020
avatar wilsonge wilsonge - merge - 11 Mar 2020
avatar wilsonge
wilsonge - comment - 11 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment