? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Mar 2020

PR #28289

Pull Request for Issue #28289

Hover background size on sidebar dashboard and quicklink icons .

avatar brianteeman brianteeman - open - 9 Mar 2020
avatar brianteeman brianteeman - change - 9 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2020
Category Administration Templates (admin)
avatar jwaisner
jwaisner - comment - 9 Mar 2020

@brianteeman The issue referenced for this PR was never confirmed. I could not replicate.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28290.

avatar jwaisner jwaisner - change - 9 Mar 2020
Priority Medium Very low
avatar Quy
Quy - comment - 9 Mar 2020

@jwaisner This is reproducible with the nightly build.

avatar Quy
Quy - comment - 9 Mar 2020

On hover, the icon is smaller resulting in flickering.

avatar jwaisner
jwaisner - comment - 9 Mar 2020

@Quy Flickering? I guess I didnt understand the issue cited for this PR being related to overlap.

avatar Quy
Quy - comment - 9 Mar 2020

The reported issue with overlapping is reproducible with the nightly build. The flickering is a separate issue from this PR.

avatar jwaisner
jwaisner - comment - 9 Mar 2020

as of commit a46cafa (latest pull from this morning) I was not able to reproduce the issue cited in the nightly build. This could have been corrected by another PR. Can you confirm with latest pull from the repo?

avatar Quy
Quy - comment - 9 Mar 2020

It appears that you did not run npm i as the menu icons in your screenshot are not larger.

avatar jwaisner
jwaisner - comment - 9 Mar 2020

I run npm ci after pulling from the repo. I stand corrected though. I reset the files and clean installed again and I see the issue. I will test the fix.

avatar jwaisner
jwaisner - comment - 9 Mar 2020

I have tested this item successfully on 2c68525


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28290.

avatar jwaisner jwaisner - test_item - 9 Mar 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 9 Mar 2020

I have not tested this item.

After reviewing this again if you move your cursor in between the dashboard icons the selector will jump between them constantly. I don't have a way to pull video of this but I don't think that is intended. Might need to adjust the hover size a bit more to prevent it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28290.

avatar jwaisner jwaisner - test_item - 9 Mar 2020 - Not tested
avatar brianteeman
brianteeman - comment - 9 Mar 2020

Try to record it with licecap. It's cross platform and open source

avatar Quy
Quy - comment - 10 Mar 2020

Put cursor between the dashboards. It will toggle between the two dashboards and the icon is smaller on hover.

dashboard

avatar brianteeman
brianteeman - comment - 10 Mar 2020

I can see the problem now and will update this PR to resolve it

avatar brianteeman brianteeman - change - 10 Mar 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 10 Mar 2020

updated

avatar brianteeman
brianteeman - comment - 10 Mar 2020

Drone errors are unrelated to this PR and hopefully fixed with #28293

avatar brianteeman
brianteeman - comment - 10 Mar 2020

@wilsonge can you restart drone please

avatar wilsonge
wilsonge - comment - 10 Mar 2020

done

avatar Quy
Quy - comment - 10 Mar 2020

I have tested this item successfully on 5098051


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28290.

avatar Quy Quy - test_item - 10 Mar 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 10 Mar 2020

I have tested this item successfully on 5098051


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28290.

avatar jwaisner jwaisner - test_item - 10 Mar 2020 - Tested successfully
avatar jwaisner jwaisner - change - 10 Mar 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 10 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28290.

avatar wilsonge wilsonge - change - 10 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-10 18:19:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 10 Mar 2020
avatar wilsonge wilsonge - merge - 10 Mar 2020
avatar wilsonge
wilsonge - comment - 10 Mar 2020

Thanks!

avatar brianteeman
brianteeman - comment - 10 Mar 2020

thanks

Add a Comment

Login with GitHub to post a comment